Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --with-python=sage-python23 to Singular configure #28676

Closed
slel opened this issue Oct 30, 2019 · 11 comments
Closed

Pass --with-python=sage-python23 to Singular configure #28676

slel opened this issue Oct 30, 2019 · 11 comments

Comments

@slel
Copy link
Member

slel commented Oct 30, 2019

Either singular should depend on the python package
or --without-python should be passed to configure. Otherwise the configure script may find some unexpected python version.

See sage-release discussion:

CC: @isuruf @slel @dimpase

Component: build

Keywords: Singular

Author: Matthias Koeppe

Branch: 68327e9

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28676

@slel slel added this to the sage-9.0 milestone Oct 30, 2019
@mkoeppe
Copy link
Member

mkoeppe commented Dec 28, 2019

Branch: u/mkoeppe/singular-configure-python

@mkoeppe
Copy link
Member

mkoeppe commented Dec 28, 2019

comment:2

This is a problem for anyone who has a python2.7 binary somewhere in PATH, for example in /usr/local/bin, coming from homebrew.

With the simple patch on this ticket, in a Python 3 build of Sage, this now gives:

[singular-4.1.1p2.p0] checking for --with-python... sage-python23
[singular-4.1.1p2.p0] checking whether sage-python23 version >= 2.4... yes
[singular-4.1.1p2.p0] checking whether sage-python23 version >= 3... too recent, skipping python interface!

New commits:

68327e928676: Pass --with-python=sage-python23 to Singular configure

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Dec 28, 2019

Author: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Dec 28, 2019

Commit: 68327e9

@mkoeppe mkoeppe changed the title Clarify Singular dependence on Python Pass --with-python=sage-python23 to Singular configure Dec 28, 2019
@dimpase
Copy link
Member

dimpase commented Dec 28, 2019

comment:3

Looks good to me. As far as I understand, it has no effect on sagelib, only on possible use of Singular's python interface outside of sagelib.

@dimpase
Copy link
Member

dimpase commented Dec 28, 2019

Reviewer: Dima Pasechnik

@kiwifb
Copy link
Member

kiwifb commented Dec 28, 2019

comment:4

Yes, there are no effects on sagelib. And as I remember py3 is not supported, so this interface will probably just die since upstream doesn't seem to be interested in porting it to a more recent python. Not that we should care.

@vbraun
Copy link
Member

vbraun commented Dec 28, 2019

Changed branch from u/mkoeppe/singular-configure-python to 68327e9

@mkoeppe
Copy link
Member

mkoeppe commented Jul 6, 2020

comment:6

Follow up in #25993 - where we change it to --without-python

@mkoeppe
Copy link
Member

mkoeppe commented Jul 6, 2020

Changed commit from 68327e9 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants