Meta-ticket: Upgrade cddlib, fix cddlib header search for packages latte_int, gfan, topcom

[mkoeppe]

Follow up from #28905.

We upgrade to 0.94m: https://repology.org/project/cddlib/versions

• latte_int: Upgrade: latte_int 1.7.6 #31482
• singular: Upgrade: Singular 4.2.0, pysingular 0.9.7 #25993
• gfan : Patch gfan to use newer cddlib header location #32243
• topcom: Update topcom to 1.1.2, fix cddlib header search #31531
• polymake: Upgrade polymake to 4.3 #28435
• cddlib: Upgrade cddlib to fix wrong intersection of polytopes #30319, sort out Debian's installation of cddlib's headers into cdd/ #34634
• make singular pick sage's cdd (if installed): prefer cddlib/ over cdd/ Singular/Singular#1064

Depends on #31482

CC: @orlitzky @dimpase @saraedum @slel @antonio-rojas @kiwifb @kliem

Component: packages: optional

Keywords: upgrade, cddlib

Author: Dima Pasechnik

Branch/Commit: 0c27c4f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29413

[slel]

Changed keywords from none to upgrade, cddlib

[slel]

comment:3

New: cddlib 0.94k was released on 2020-09-15.

• https://github.com/cddlib/cddlib/releases

[dimpase]

comment:4

a newer cdd 0.94m fixing #30319 has been released

[mkoeppe]

comment:5

Are there already patches around for the cdd header file locations for gfan and topcom?

[kiwifb]

comment:6

For cddlib, this is a bit upsetting. We compile in Gentoo and in sage with -DNOCDDPREFIX which trigger block like this

#ifdef NOCDDPREFIX
#include "setoper.h"
#include "cdd.h"
#include "cdd_f.h"
#else
#include "cdd/setoper.h"
#include "cdd/cdd.h"
#include "cdd/cdd_f.h"
#endif

in src/lp_cdd.cpp, src/gfanlib_zcone.cpp and src/app_librarytest.cpp. So, it feels a bit stupid now that the prefix is cddlib. But at least the patch should be easy and then remove the -DNOCDDPREFIX from CXXFLAGS.

[kiwifb]

comment:7

nix has a patch to go with the removal of -DNOCDDPREFIX. However, there is a simpler fix. gfan only install binaries and no headers. Adding -Ipath_to/include/cddlib to CXXFLAGS will allow compilation and it is compatible with older cddlib too. I'll look at topcom next.

[mkoeppe]

comment:8

Replying to @kiwifb:

However, there is a simpler fix. gfan only install binaries and no headers. Adding -Ipath_to/include/cddlib to CXXFLAGS will allow compilation and it is compatible with older cddlib too.

This is not a good fix. All of these packages should be modified (with proper upstreamable patches) so that they look for upstream's official new header name cddlib/cdd.h in the normal user-provided include path.

[kiwifb]

comment:9

That's easy enough to do. I would hope the fix has already been forwarded to the gfan people. Upstream is overdue for a maintenance release :)

[kiwifb]

comment:10

For topcom I am going to advocate adding to CPPFLAGS for now. Because upstream is a serial vendorer and its build system relies exclusively on vendored versions. Once we can get that upstream to get out of vendoring we may be able to suggest patches to them. But right now the point is moot.

[kiwifb]

comment:11

And topcom has a new version: 0.17.8 (still massively vendoring).

[kiwifb]

comment:12

Now that I see how much you already patched topcom, it is trivial to add a little love for cddlib at https://github.com/sagemath/sage-prod/blob/develop/build/pkgs/topcom/patches/configure.ac#L63

[kliem]

comment:13

I think I got it figured out for latte now: latte-int/latte#23

There is a couple of scenarios that could happen:

• System cdd in:
  • inclusion directory
  • cdd/
  • cddlib'
• Sages cdd in:
  • inclusion directory (of sage)
  • cddlib/ (once cdd is upgraded)

[mkoeppe]

Dependencies: #31482

[mkoeppe]

comment:18

Also need to check polymake.

[jhpalmieri]

comment:30

Is the last issue ("make singular pick sage's cdd") resolved? The Singular change is marked as "merged", and I've been using homebrew's cddlib and singular on at least one OS X machine for a while with no apparent issues.

[dimpase]

comment:31

let's reenable cddlib for Homebrew.

[dimpase]

Author: Dima Pasechnik

[dimpase]

New commits:

add35c4

allow Homebrew's cddlib

[dimpase]

Branch: u/dimpase/configure/cdd_on_homebrew

[dimpase]

Commit: add35c4

[jhpalmieri]

comment:33

Good idea. Is there any reason to keep this meta-ticket open and handle homebrew/cddlib elsewhere? Otherwise, I'm happy with this change.

[mkoeppe]

comment:34

I think also the comment in build/pkgs/cddlib/spkg-configure.m4 should be updated so that it does not talk about this ticket as something for the future

[sagetrac-git]

Changed commit from add35c4 to 9ee86ae

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9ee86ae

reflect the progress on #29413 in comments

[dimpase]

comment:36

I've opened #34634 to deal with the renaming cddlib/->cdd/ of headers' subdir on Debian.

[mkoeppe]

comment:38

Another update on debian please for the comment

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0c27c4f

all good on Debian

[sagetrac-git]

Changed commit from 9ee86ae to 0c27c4f

[dimpase]

comment:40

Replying to Matthias Köppe:

Another update on debian please for the comment

done in ​0c27c4f

[mkoeppe]

comment:41

Thanks. Should #31531 be a dependency?

[mkoeppe]

Reviewer: Matthias Koeppe

[dimpase]

comment:42

I don't see how #31531 is a dependency to this Homebrew-specific branch.

[mkoeppe]

comment:43

ok then

[vbraun]

Changed branch from u/dimpase/configure/cdd_on_homebrew to 0c27c4f