Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doctests of Degenerate Submanifold #29440

Closed
kliem opened this issue Mar 31, 2020 · 11 comments
Closed

Improve doctests of Degenerate Submanifold #29440

kliem opened this issue Mar 31, 2020 · 11 comments

Comments

@kliem
Copy link
Contributor

kliem commented Mar 31, 2020

The doctests in sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py have problems with time outs.

See for example:

Part of the problem might be, that the file makes no use of long time flags (testing takes 86 seconds on a fast computer without --long).

We add those flags and some smaller examples to display functionality of the module. This brings down testing time without `--long`` to less than 30 seconds.

CC: @sagetrac-Dicolevrai @egourgoulhon @mkoeppe

Component: geometry

Keywords: degenerate manifolds

Author: Jonathan Kliem

Branch/Commit: 848fec0

Reviewer: Hans Fotsing Tetsing

Issue created by migration from https://trac.sagemath.org/ticket/29440

@kliem kliem added this to the sage-9.1 milestone Mar 31, 2020
@kliem
Copy link
Contributor Author

kliem commented Mar 31, 2020

Branch: public/29440

@kliem
Copy link
Contributor Author

kliem commented Mar 31, 2020

New commits:

ef94ca5use # long time and add a smaller example

@kliem
Copy link
Contributor Author

kliem commented Mar 31, 2020

Commit: ef94ca5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Changed commit from ef94ca5 to 848fec0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

848fec0removed redundant import

@sagetrac-Dicolevrai
Copy link
Mannequin

sagetrac-Dicolevrai mannequin commented Apr 2, 2020

Replying to @kliem:

The doctests in sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py have problems with time outs.

See for example:

Part of the problem might be, that the file makes no use of long time flags (testing takes 86 seconds on a fast computer without --long).

We add those flags and some smaller examples to display functionality of the module. This brings down testing time without `--long`` to less than 30 seconds.

Thank you so much for the improvement and the example!

@fchapoton
Copy link
Contributor

comment:5

please add missing reviewer full name

@sagetrac-Dicolevrai
Copy link
Mannequin

sagetrac-Dicolevrai mannequin commented Apr 3, 2020

Changed author from Jonathan Kliem to none

@sagetrac-Dicolevrai
Copy link
Mannequin

sagetrac-Dicolevrai mannequin commented Apr 3, 2020

Reviewer: Hans Fotsing Tetsing

@kliem
Copy link
Contributor Author

kliem commented Apr 3, 2020

Author: Jonathan Kliem

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from public/29440 to 848fec0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants