Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: Various CI fixes #29929

Closed
mkoeppe opened this issue Jun 21, 2020 · 40 comments
Closed

tox.ini: Various CI fixes #29929

mkoeppe opened this issue Jun 21, 2020 · 40 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 21, 2020

  • Add a homebrew environment local-homebrew-macos-usrlocal that uses the global homebrew in /usr/local. This will be faster and may be more robust for GitHub Actions builds because "bottles" of more packages can be used. (For a while, for example, all homebrew-standard builds fail because the homebrew ppl package cannot be installed from source - "brew install -s ppl" fails - 401 Unauthorized Homebrew/homebrew-core#57499)

  • Disable testsuites that need pip (ssl)

This is on top of:

Depends on #29851
Depends on #29105
Depends on #30064
Depends on #30048
Depends on #30088
Depends on #30118

Upstream: Reported upstream. No feedback yet.

CC: @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: b62f775

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29929

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 21, 2020
@jhpalmieri
Copy link
Member

comment:1

I'll repeat a comment I made at #29706: I really needed an environment without homebrew to replicate the failures; just having a minimal homebrew installation, or having one with temporarily moved pkgconfig directories, wasn't enough to get the failures.

(So I'm emphasizing that I'm agreeing with the summary: "without homebrew".)

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2020

Upstream: Reported upstream. No feedback yet.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2020

Dependencies: #29851, #29105

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title tox.ini: Add a macos environment without homebrew, conda tox.ini: Add a macos environment without homebrew, conda; and other CI fixes Jul 5, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title tox.ini: Add a macos environment without homebrew, conda; and other CI fixes tox.ini: Various CI fixes Jul 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2020

Changed dependencies from #29851, #29105 to #29851, #29105, #30064

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

Commit: bfb2fb4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

New commits:

539c182build/make/install: Do not depend on src/bin/sage-version.sh
761092cMerge branch 't/29987/build_make_install__do_not_depend_on_src_bin_sage_version_sh' into t/30064/fix_tox_docker_builds_broken_by__29884
f2efa6asrc/doc/bootstrap: Create the directory src/doc/en/reference/repl if it does not exist
b7bf43bbuild/bin/write-dockerfile.sh: ADD src/bin for bootstrapping, needed by src/doc/bootstrap after #29884
365ce61Merge branch 'u/mkoeppe/fix_tox_docker_builds_broken_by__29884' of git://trac.sagemath.org/sage into HEAD
1e7becctox.ini [debian-buster, -sid]: IGNORE_MISSING_SYSTEM_PACKAGES=yes because of libpython3.7-dev
fb61a31Merge branch 'u/mkoeppe/tox_ini__debian_bullseye___sid_have_python3_8_instead_of_3_7' of git://trac.sagemath.org/sage into 9.2.beta3+ci-fixes
bfb2fb4tox.ini: Add environment local-homebrew-usrlocal

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

Changed dependencies from #29851, #29105, #30064 to #29851, #29105, #30064, #30088

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2020

Changed dependencies from #29851, #29105, #30064, #30088 to #29851, #29105, #30064, #30048, #30088

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

aded967Merge commit '8195cb821e01e0cb627240d7135d5634c265cab0' of git://trac.sagemath.org/sage into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda
07d657dMerge tag '9.2.beta4' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Changed commit from bfb2fb4 to 07d657d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Changed commit from 07d657d to bd15fb9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bd15fb9build/bin/write-dockerfile.sh, tox.ini: Do not run testsuites that need pip (ssl)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

Changed dependencies from #29851, #29105, #30064, #30048, #30088 to #29851, #29105, #30064, #30048, #30088, #30118

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

25393b0Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg
5aca238Merge branch 't/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2020

Changed commit from bd15fb9 to 5aca238

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Changed commit from 5aca238 to d1a2cbf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a17c655m4/sage_spkg_collect.m4: Do not include script packages in SAGE_SDIST_PACKAGES
827923abootstrap: Accept 2020s in config.guess version check
c30ac54tox.ini: Add local-nobootstrap
de6464d.github/workflows/tox.yml: Add jobs "dist", "local-macos-nohomebrew
775b7f7Trac #30088: add a few explanatory comments to m4/sage_spkg_collect.m4.
160862fm4/sage_spkg_collect.m4: Mention sagelib in the comment
d1a2cbfMerge branch 't/30088/fix__make_sdist___add_test_run_to_github_actions' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

comment:21

is this still "new"?

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

comment:23

The cygwin CI wishlist has been moved to #30154.

Needs review

@kliem
Copy link
Contributor

kliem commented Jul 22, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jul 22, 2020

comment:24

Looks reasonable.

Can you provide an example of this ticket in action (you probably have been using it already anyway?).

What's symengine_py?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 22, 2020

comment:25

Replying to @kliem:

What's symengine_py?

See #29497

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 22, 2020

comment:26

Replying to @kliem:

Can you provide an example of this ticket in action (you probably have been using it already anyway?).

The SAGE_CHECK_PACKAGES adjustments are used in #29766.

@kliem
Copy link
Contributor

kliem commented Jul 23, 2020

comment:27

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 23, 2020

comment:28

Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 25, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b62f775Merge tag '9.2.beta6' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 25, 2020

Changed commit from d1a2cbf to b62f775

@vbraun
Copy link
Member

vbraun commented Jul 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants