Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sagetex to version 3.5 #30342

Closed
dimpase opened this issue Aug 12, 2020 · 14 comments
Closed

update sagetex to version 3.5 #30342

dimpase opened this issue Aug 12, 2020 · 14 comments

Comments

@dimpase
Copy link
Member

dimpase commented Aug 12, 2020

tarball: see upstream_url in checksums

CC: @mkoeppe @kcrisman

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: 5841a70

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/30342

@dimpase dimpase added this to the sage-9.2 milestone Aug 12, 2020
@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2020

Branch: u/dimpase/packages/sagetex35

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2020

Commit: 5841a70

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2020

New commits:

5841a70update to 3.5

@dimpase

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Reviewer: github.com/mkoeppe/sage/actions/runs/206174675, ...

@dimpase
Copy link
Member Author

dimpase commented Aug 13, 2020

comment:4

sagetex needs manual testing, there is little in terms of Sage doctests for it.

@dcoudert
Copy link
Contributor

comment:5

build ok on macOS 10.14.6. What should I do to test it ?

@kcrisman
Copy link
Member

comment:6

build ok on macOS 10.14.6. What should I do to test it ?

Trying to build the sample article in the package is a good place. See the upstream readme for instructions.

@dcoudert
Copy link
Contributor

comment:7

I followed the compile instructions and it when well. The dvi file sagetex.dvi is properly generated and displayed.

However, instead of file sagetex.sage, I have sagetex.sagetex.sage. So instead of running sage sagetex.sage, I used sage sagetex.sagetex.sage. I also have files sagetex.sagetex.sage.py, sagetex.sagetex.scmd, sagetex.sagetex.sout.

@dcoudert
Copy link
Contributor

Changed reviewer from github.com/mkoeppe/sage/actions/runs/206174675, ... to David Coudert, github.com/mkoeppe/sage/actions/runs/206174675, ...

@dimpase
Copy link
Member Author

dimpase commented Aug 19, 2020

comment:8

Replying to @dcoudert:

I followed the compile instructions and it when well. The dvi file sagetex.dvi is properly generated and displayed.

However, instead of file sagetex.sage, I have sagetex.sagetex.sage. So instead of running sage sagetex.sage, I used sage sagetex.sagetex.sage. I also have files sagetex.sagetex.sage.py, sagetex.sagetex.scmd, sagetex.sagetex.sout.

this is normal, e.g. for the example.tex one gets

example.aux              example.out              example.sagetex.sage     example.sagetex.scmd     example.tex              
example.log              example.pdf              example.sagetex.sage.py  example.sagetex.sout 

and this used to be the case for several previous versions. The file extension of these temporary files is always .sagetex.*.

@dcoudert
Copy link
Contributor

comment:9

So then, LGTM.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 19, 2020

Changed reviewer from David Coudert, github.com/mkoeppe/sage/actions/runs/206174675, ... to David Coudert

@vbraun
Copy link
Member

vbraun commented Aug 20, 2020

Changed branch from u/dimpase/packages/sagetex35 to 5841a70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants