Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sagetex to version 3.6.1 #32887

Closed
dimpase opened this issue Nov 16, 2021 · 156 comments
Closed

update sagetex to version 3.6.1 #32887

dimpase opened this issue Nov 16, 2021 · 156 comments

Comments

@dimpase
Copy link
Member

dimpase commented Nov 16, 2021

Previous update: #30342, merged 2020-08-20.

Depends on #34219

CC: @kcrisman @mkoeppe @orlitzky @slel @jhpalmieri @EmmanuelCharpentier

Component: packages: standard

Author: Dima Pasechnik, Matthias Koeppe

Branch/Commit: add10cd

Reviewer: Emmanuel Charpentier

Issue created by migration from https://trac.sagemath.org/ticket/32887

@dimpase dimpase added this to the sage-9.5 milestone Nov 16, 2021
@dimpase
Copy link
Member Author

dimpase commented Nov 16, 2021

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Nov 16, 2021

New commits:

9e26d0aupdate sagetex to version 3.6

@dimpase
Copy link
Member Author

dimpase commented Nov 16, 2021

Commit: 9e26d0a

@dimpase
Copy link
Member Author

dimpase commented Nov 16, 2021

Branch: u/dimpase/packages/sagetex/v3.6

@mkoeppe
Copy link
Member

mkoeppe commented Nov 16, 2021

comment:2

sagetex has a new dependency, pyparsing, that also needs to be added as dependency of the SPKG. - https://github.com/sagemath/sagetex/blob/master/setup.py#L16

And the 3.6 release is defective - it still identifies itself as 3.5 - https://github.com/sagemath/sagetex/blob/master/setup.py#L7

@mkoeppe
Copy link
Member

mkoeppe commented Nov 16, 2021

comment:3

Or, rather, what is on https://github.com/sagemath/sagetex/ does not match what is packaged up in the release tarball

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

180f8a1correct version in setup.py, and deps

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2021

Changed commit from 9e26d0a to 180f8a1

@dimpase
Copy link
Member Author

dimpase commented Nov 17, 2021

comment:5

should all be fixed now, sorry. To much different metadata to tie up manually here...

@dimpase
Copy link
Member Author

dimpase commented Nov 17, 2021

comment:6

I think I'll eventually add a small configure script to set up all the versions right.
If only there was a way to put tarballs up on GitHub and creating GitHub releases from
the command line.

@mkoeppe
Copy link
Member

mkoeppe commented Nov 17, 2021

comment:7

What is the tarball doing on GitHub?
Is it not supposed to be on CTAN (https://ctan.org/pkg/sagetex?lang=en) or on PyPI?

@dimpase
Copy link
Member Author

dimpase commented Nov 17, 2021

comment:8

Replying to @mkoeppe:

What is the tarball doing on GitHub?
Is it not supposed to be on CTAN (https://ctan.org/pkg/sagetex?lang=en) or on PyPI?

there is something called sagetex.zip on CTAN - but the process of publishing there is manual, and I have not put this there yet.

And I don't know anything about PyPI publishing.

@kcrisman
Copy link
Member

comment:9

Is it not supposed to be on CTAN (https://ctan.org/pkg/sagetex?lang=en) or on PyPI?

Unless something has changed, we do not want it on CTAN, because that will not match versions with Sage. Dan always made sure that the versions matched (indeed, I think this is in the release instructions for SageTeX?) and so one has to manually move the .sty file, or did have to do.

@dimpase
Copy link
Member Author

dimpase commented Nov 17, 2021

comment:10

Hmm, what do you mean by "we don't want it on CTAN"? Have you forgotten how we started putting in on CTAN few years ago? (And I did it for versions 3.4 and 3.5, and will do for 3.6)

@saraedum
Copy link
Member

comment:11

Replying to @dimpase:

I think I'll eventually add a small configure script to set up all the versions right.
If only there was a way to put tarballs up on GitHub and creating GitHub releases from
the command line.

Have you looked into rever? I use it to create tarballs for autoconfiscated packages, release them on GitHub and on PyPI. See, e.g., https://github.com/flatsurf/flatsurf/blob/master/rever.xsh.

@kcrisman
Copy link
Member

comment:12

Unless something has changed,

Apparently it has.

Hmm, what do you mean by "we don't want it on CTAN"? Have you forgotten how we started putting in on CTAN few years ago? (And I did it for versions 3.4 and 3.5, and will do for 3.6)

That is good news, and I hope it will keep track with the Sage versions well.

@dimpase
Copy link
Member Author

dimpase commented Nov 18, 2021

comment:13

Replying to @kcrisman:

Unless something has changed,

Apparently it has.

Hmm, what do you mean by "we don't want it on CTAN"? Have you forgotten how we started putting in on CTAN few years ago? (And I did it for versions 3.4 and 3.5, and will do for 3.6)

That is good news, and I hope it will keep track with the Sage versions well.

Karl, it's almost 2 years old news:

Date: Thu, 24 Jan 2019 18:50:56 +0000
References: <CAKqbAeFMwHMHYbOfA7SOXOJuuv6aBU=89R0Cz8iddJxkmg+64g@mail.gmail.com>
In-Reply-To: <CAKqbAeFMwHMHYbOfA7SOXOJuuv6aBU=89R0Cz8iddJxkmg+64g@mail.gmail.com>
Message-ID: <CAAWYfq211+bChdmArcJAPwK62opKnSxEfERmtS_xBbcV3kEH_A@mail.gmail.com>
Subject: Re: are you guys the CTAN maintainers for SageTeX now?
From: Dima Pasechnik <...>
To: Dan Drake <...>
Cc: Karl-Dieter Crisman <...>
Content-Type: text/plain; charset="UTF-8"

Hi Dan,
the update is in! cf https://ctan.org/pkg/sagetex?lang=en
Cheers,
Dima

On Wed, Jan 23, 2019 at 1:45 AM Dan Drake <> wrote:
>
> Hi Karl-Dieter, Dima,
>
> Following up -- I see the reply from the CTAN guy. Are you guys now considered the CTAN maintainers for SageTeX? Can you update or remove it?
>
> --
> Ceci n'est pas une .signature.

@kcrisman
Copy link
Member

comment:14

Karl, it's almost 2 years old news:

I give up. I clearly can no longer keep 'Trac'.

@dimpase
Copy link
Member Author

dimpase commented Dec 3, 2021

comment:15

Replying to @dimpase:

Replying to @mkoeppe:

What is the tarball doing on GitHub?
Is it not supposed to be on CTAN (https://ctan.org/pkg/sagetex?lang=en) or on PyPI?

there is something called sagetex.zip on CTAN - but the process of publishing there is manual, and I have not put this there yet.

And I don't know anything about PyPI publishing.

The package's Python code (apart from setup.py) is generated by TeX from a .dtx file.
Anyhow, I tried uploading its Makefile-created tarball (one used by Sage) anf got

$ twine upload  dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading sagetex-3.6.tar.gz
100%|████████████████████████| 71.0k/71.0k [00:00<00:00, 73.0kB/s]
Error during upload. Retry with the --verbose option for more details.
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
The name 'sagetex' isn't allowed. See https://pypi.org/help/#project-name for more information.

Perhaps some metadata is missing, I don't know. There is no sagetex project on PyPI as far as I can tell.

Let's get this in as is, and deal with a better distribution mechanism later.

@orlitzky
Copy link
Contributor

orlitzky commented Dec 5, 2021

comment:17

Is sagetex actually used by sage? TBH I've managed to avoid it until now.

@dimpase
Copy link
Member Author

dimpase commented Dec 5, 2021

comment:18

No, sagetex is a !Sage/Latex package.
It's hard to spin it off, cause as a Python package, almost all of it is generated by running TeX on a .dtx file.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from 3c0f87e to 6e5af72

@mkoeppe
Copy link
Member

mkoeppe commented Aug 20, 2022

comment:136
[sagetex-3.6]   copying example.tex -> build/bdist.macosx-10.14-x86_64/wheel/sagetex-3.6.data/data/share/doc/sagetex
[sagetex-3.6]   error: can't copy 'sagetex.pdf': doesn't exist or not a regular file

@mkoeppe
Copy link
Member

mkoeppe commented Aug 20, 2022

comment:137

OK, that was pointed out in comment:41 already.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

add10cdbuild/pkgs/sagetex: Use 3.6.1 release on PyPI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from 6e5af72 to add10cd

@mkoeppe mkoeppe changed the title update sagetex to version 3.6 update sagetex to version 3.6.1 Aug 20, 2022
@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Aug 21, 2022

comment:141

Replying to @mkoeppe:

Now we need fearless centaur testers

The centaur runs ... and passes ptestlong. Yay !

==> positive_review.

Thanks a lot !

@dimpase
Copy link
Member Author

dimpase commented Aug 21, 2022

comment:142

Does

SAGE_CHECK=yes make sagetex

pass?

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Aug 21, 2022

comment:143

Sorry for the wait (family obligations... ;-)

Replying to @dimpase:

Does

SAGE_CHECK=yes make sagetex

pass?

Yep !

HTH,

@mkoeppe
Copy link
Member

mkoeppe commented Aug 21, 2022

comment:144

Thanks for the review!

@mkoeppe
Copy link
Member

mkoeppe commented Aug 21, 2022

Reviewer: Emmanuel Charpentier

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/packages/sagetex/v3.6 to add10cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants