Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GAP, PARI, Singular Jupyter kernels from Docker image #31372

Closed
mkoeppe opened this issue Feb 10, 2021 · 18 comments
Closed

Remove GAP, PARI, Singular Jupyter kernels from Docker image #31372

mkoeppe opened this issue Feb 10, 2021 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 10, 2021

(from https://groups.google.com/g/sage-release/c/hVIsURxpdhc/m/0h-_jT6mCQAJ)

pari_jupyter is not compatible with Python 3.9,
breaks Docker build on GitLab.

Reported upstream at sagemath/pari-jupyter#9

Given that, we simplify our Dockerfile to skip
three optional packages it used to install:
gap_jupyter, pari_jupyter, singular_jupyter.

Upstream: Reported upstream. No feedback yet.

CC: @fchapoton @kiwifb @antonio-rojas @videlec

Component: packages: optional

Author: Matthias Koeppe

Branch: 2cbfe78

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31372

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2021

Upstream: Reported upstream. No feedback yet.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2021

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2021

New commits:

2cbfe78docker/Dockerfile: Do not reinstall standard packages with pip; do not install optional packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2021

Commit: 2cbfe78

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

comment:4

Needs review.

@fchapoton
Copy link
Contributor

comment:5

I would prefer to comment out the line, with the idea to put it back when/if this is fixed

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2021

comment:6

I removed them because they are optional packages, and I don't think the docker image should install them by default. If these packages should be present in every installation, someone should make the case for them to be standard packages -- which will ensure that they are actually tested.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

ok

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2021

comment:8

Thanks!

@slel

This comment has been minimized.

@slel slel changed the title pari_jupyter is not compatible with python 3.9, breaks docker build on gitlab Remove GAP, PARI, Singular Jupyter kernels from Docker image Feb 21, 2021
@slel

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Mar 1, 2021

@slel
Copy link
Member

slel commented Apr 8, 2021

Changed commit from 2cbfe78 to none

@slel
Copy link
Member

slel commented Apr 8, 2021

comment:12

Some pointers as we stop shipping the GAP, PARI
and Singular Jupyter kernels in our Docker image.

The repo for the GAP Jupyter kernel is at:

To try GAP with Jupyter online, see:

The repo for the PARI Jupyter kernel is at:

Solving the issue that broke things here is tracked at:

See also "Run PARI/GP in your browser" including WebAssembly version:

The repo for the Singular Jupyter kernel is at:

See also the documentation page:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants