Update markupsafe to 2.1.1, jinja2 to 3.1.2 #31937

isuruf · 2021-06-08T23:36:05Z

Getting this warning with markupsafe 2.0.1

DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

The new versions:

https://github.com/pallets/markupsafe/blob/main/CHANGES.rst
https://jinja.palletsprojects.com/en/3.1.x/changes/
still support Python 3.7, so this update would even be safe for Sage 9.6

CC: @slel @antonio-rojas @kiwifb @egourgoulhon

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 037fc2f

Reviewer: Isuru Fernando, François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/31937

The text was updated successfully, but these errors were encountered:

mkoeppe · 2021-06-11T20:11:20Z

comment:1

markupsafe is only used by jinja2. We should update that as well, from 2.11.2 to 2.11.3 or 3.0.1

mkoeppe · 2021-06-11T20:17:25Z

Branch: u/mkoeppe/update_markupsafe_to_2_0_1

mkoeppe · 2021-06-11T20:18:14Z

Author: Matthias Koeppe

mkoeppe · 2021-06-11T20:18:14Z

Commit: a462a1d

mkoeppe · 2021-06-11T20:18:14Z

New commits:

`1d4a709`	`build/pkgs/markupsafe: Update to 2.0.1`
`a462a1d`	`build/pkgs/jinja2: Update to 3.0.1`

isuruf · 2021-06-11T20:52:12Z

comment:5

LGTM. Thanks

isuruf · 2021-06-11T20:54:52Z

Reviewer: Isuru Fernando

mkoeppe · 2021-06-11T21:50:52Z

comment:7

Thanks!

vbraun · 2021-06-23T22:53:01Z

comment:8

I'm getting lots of

**********************************************************************
File "src/sage_docbuild/__init__.py", line 93, in sage_docbuild.builder_helper
Failed example:
    from sage_docbuild import DocBuilder, setup_parser
Expected nothing
Got:
    doctest:warning
      File "/home/release/Sage/src/bin/sage-runtests", line 144, in <module>
        err = DC.run()
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/control.py", line 1207, in run
        self.run_doctests()
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/control.py", line 909, in run_doctests
        self.dispatcher.dispatch()
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 2040, in dispatch
        self.parallel_dispatch()
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 1935, in parallel_dispatch
        w.start()  # This might take some time
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 2207, in start
        super(DocTestWorker, self).start()
      File "/usr/lib64/python3.9/multiprocessing/process.py", line 121, in start
        self._popen = self._Popen(self)
      File "/usr/lib64/python3.9/multiprocessing/context.py", line 224, in _Popen
        return _default_context.get_context().Process._Popen(process_obj)
      File "/usr/lib64/python3.9/multiprocessing/context.py", line 277, in _Popen
        return Popen(process_obj)
      File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 19, in __init__
        self._launch(process_obj)
      File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 71, in _launch
        code = process_obj._bootstrap(parent_sentinel=child_r)
      File "/usr/lib64/python3.9/multiprocessing/process.py", line 315, in _bootstrap
        self.run()
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 2179, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 2508, in __call__
        doctests, extras = self._run(runner, options, results)
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 2555, in _run
        result = runner.run(test)
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 906, in run
        return self._run(test, compileflags, out)
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage/doctest/forker.py", line 1133, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage_docbuild.builder_helper[0]>", line 1, in <module>
        from sage_docbuild import DocBuilder, setup_parser
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sage_docbuild/__init__.py", line 55, in <module>
        import sphinx.ext.intersphinx
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sphinx/ext/intersphinx.py", line 40, in <module>
        from sphinx.application import Sphinx
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sphinx/application.py", line 42, in <module>
        from sphinx.registry import SphinxComponentRegistry
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sphinx/registry.py", line 24, in <module>
        from sphinx.builders import Builder
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sphinx/builders/__init__.py", line 26, in <module>
        from sphinx.util import import_object, logging, rst, progress_message, status_iterator
      File "<frozen importlib._bootstrap>", line 1058, in _handle_fromlist
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 855, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/home/release/Sage/local/lib64/python3.9/site-packages/sphinx/util/rst.py", line 58, in <module>
        def heading(env: Environment, text: str, level: int = 1) -> str:
      File "/home/release/Sage/local/lib64/python3.9/site-packages/jinja2/filters.py", line 90, in environmentfilter
        warnings.warn(
      File "/usr/lib64/python3.9/warnings.py", line 109, in _showwarnmsg
        sw(msg.message, msg.category, msg.filename, msg.lineno,
    :
    DeprecationWarning: 'environmentfilter' is renamed to 'pass_environment', the old name will be removed in Jinja 3.1.
**********************************************************************
1 item had failures:
   1 of  10 in sage_docbuild.builder_helper
    [39 tests, 1 failure, 0.31 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage_docbuild/__init__.py  # 1 doctest failed
----------------------------------------------------------------------

mkoeppe · 2021-06-23T22:55:44Z

comment:9

Looks like this needs to wait for the sphinx update in #31696

mkoeppe · 2021-06-23T22:55:44Z

Dependencies: #31696

mkoeppe · 2021-07-19T00:44:56Z

comment:11

Setting a new milestone for this ticket based on a cursory review.

mkoeppe · 2021-09-16T03:50:39Z

Changed dependencies from #31696 to #32518

sagetrac-git · 2022-04-21T05:03:43Z

Changed commit from a462a1d to 6dbbf39

sagetrac-git · 2022-04-21T05:03:43Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`005f923`	`build/pkgs/markupsafe: Update to 2.0.1`
`3fd3429`	`build/pkgs/jinja2: Update to 3.0.1`
`dd9604c`	`build/pkgs/jinja2: Update to 3.1.1`
`6dbbf39`	`build/pkgs/markupsafe: Update to 2.1.1`

mkoeppe · 2022-04-21T05:04:00Z

Changed dependencies from #32518 to none

sagetrac-git · 2022-05-26T16:48:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`037fc2f`	`build/pkgs/jinja2: Update to 3.1.2`

sagetrac-git · 2022-05-26T16:48:03Z

Changed commit from 6dbbf39 to 037fc2f

kiwifb · 2022-05-27T02:21:02Z

comment:22

LGTM

kiwifb · 2022-05-27T02:21:02Z

Changed reviewer from Isuru Fernando to Isuru Fernando, François Bissey

mkoeppe · 2022-05-27T02:36:32Z

comment:23

Thanks!

vbraun · 2022-05-29T11:29:18Z

Changed branch from u/mkoeppe/update_markupsafe_to_2_0_1 to 037fc2f

isuruf added this to the sage-9.4 milestone Jun 8, 2021

isuruf added c: packages: standard labels Jun 8, 2021

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Update markupsafe to 2.0.1~~ Update markupsafe to 2.0.1, jinja2 to 3.0.1 Jun 11, 2021

mkoeppe added t: enhancement labels Jun 11, 2021

isuruf added s: positive review and removed s: needs review labels Jun 11, 2021

vbraun added s: needs work and removed s: positive review labels Jun 23, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021

mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Update markupsafe to 2.0.1, jinja2 to 3.0.1~~ Update markupsafe to 2.1.1, jinja2 to 3.1.1 Apr 21, 2022

mkoeppe added s: needs review and removed s: needs work labels Apr 21, 2022

mkoeppe changed the title ~~Update markupsafe to 2.1.1, jinja2 to 3.1.1~~ Update markupsafe to 2.1.1, jinja2 to 3.1.2 May 26, 2022

kiwifb added s: positive review and removed s: needs review labels May 27, 2022

vbraun removed the s: positive review label May 29, 2022

vbraun closed this as completed in a8c488f May 29, 2022

mkoeppe mentioned this issue Apr 2, 2022

jupyterlab: Use jupyterlab-server < 2.11 #33607

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update markupsafe to 2.1.1, jinja2 to 3.1.2 #31937

Update markupsafe to 2.1.1, jinja2 to 3.1.2 #31937

isuruf commented Jun 8, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

This comment has been minimized.

mkoeppe commented Jun 11, 2021

isuruf commented Jun 11, 2021

isuruf commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

vbraun commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

mkoeppe commented Jul 19, 2021

mkoeppe commented Sep 16, 2021

This comment has been minimized.

sagetrac-git mannequin commented Apr 21, 2022

sagetrac-git mannequin commented Apr 21, 2022

mkoeppe commented Apr 21, 2022

sagetrac-git mannequin commented May 26, 2022

sagetrac-git mannequin commented May 26, 2022

kiwifb commented May 27, 2022

kiwifb commented May 27, 2022

mkoeppe commented May 27, 2022

vbraun commented May 29, 2022

Update markupsafe to 2.1.1, jinja2 to 3.1.2 #31937

Update markupsafe to 2.1.1, jinja2 to 3.1.2 #31937

Comments

isuruf commented Jun 8, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

This comment has been minimized.

mkoeppe commented Jun 11, 2021

isuruf commented Jun 11, 2021

isuruf commented Jun 11, 2021

mkoeppe commented Jun 11, 2021

vbraun commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

mkoeppe commented Jul 19, 2021

mkoeppe commented Sep 16, 2021

This comment has been minimized.

sagetrac-git mannequin commented Apr 21, 2022

sagetrac-git mannequin commented Apr 21, 2022

mkoeppe commented Apr 21, 2022

sagetrac-git mannequin commented May 26, 2022

sagetrac-git mannequin commented May 26, 2022

kiwifb commented May 27, 2022

kiwifb commented May 27, 2022

mkoeppe commented May 27, 2022

vbraun commented May 29, 2022