Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab: Use jupyterlab-server < 2.11 #33607

Closed
mkoeppe opened this issue Mar 30, 2022 · 9 comments
Closed

jupyterlab: Use jupyterlab-server < 2.11 #33607

mkoeppe opened this issue Mar 30, 2022 · 9 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 30, 2022

Versions of jupyterlab-server >= 2.11 require jinja2 >= 3, which is incompatible. https://github.com/jupyter-server/jupyter_server/blob/main/CHANGELOG.md

This leads to errors when creating a new jupyter notebook:

      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/notebook/templates/notebook.html", line 115, in block 'header'
        {% for exporter in get_frontend_exporters() %}
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/notebook/notebook/handlers.py", line 23, in get_frontend_exporters
        from nbconvert.exporters.base import get_export_names, get_exporter
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/nbconvert/__init__.py", line 4, in <module>
        from .exporters import *
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/nbconvert/exporters/__init__.py", line 3, in <module>
        from .html import HTMLExporter
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/nbconvert/exporters/html.py", line 14, in <module>
        from jinja2 import contextfilter
    ImportError: cannot import name 'contextfilter' from 'jinja2' (/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/jinja2/__init__.py)

Our upgrade for jinja2 is stuck in #31937, so we set a version bound here.

CC: @egourgoulhon

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 09c3fd2

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/33607

@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 30, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2022

Commit: 09c3fd2

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2022

New commits:

09c3fd2build/pkgs/jupyterlab: Use jupyterlab-server < 2.11

@egourgoulhon
Copy link
Member

comment:3

LGTM. I understand that #31937 will not be ready for Sage 9.6.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2022

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 2, 2022

Changed branch from u/mkoeppe/jupyterlab__use_jupyterlab_server___2_11 to 09c3fd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants