Update polymake to 4.5, change from experimental to optional

[mkoeppe]

https://polymake.org/doku.php/news/release_4_5 (2021-09-29)

Previous update: 4.4 (#27745)

Depends on #31163

CC: @kliem @tscrim @sagetrac-tmonteil @simon-king-jena

Component: packages: optional

Author: Matthias Koeppe

Branch: 015b899

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32605

[mkoeppe]

comment:2

[polymake-4.5] checking perl module Term::ReadKey ... failed
[polymake-4.5] WARNING: perl module Term::ReadKey required for polymake not found on your machine.
[polymake-4.5]          Please be sure to install it prior to starting to use polymake. 
[}}}

[mkoeppe]

comment:4

sage -t --random-seed=0 src/sage/interfaces/polymake.py
**********************************************************************
File "src/sage/interfaces/polymake.py", line 2185, in sage.interfaces.polymake.PolymakeExpect._eval_line
Failed example:
    c                                 # optional - polymake
Expected:
    cube of dimension 15
Got:
    <repr(<sage.interfaces.polymake.PolymakeElement at 0x4141d9f80>) failed: sage.interfaces.polymake.PolymakeError: Can't locate object method "description" via package "1" (perhaps you forgot to load "1"?)>
**********************************************************************
File "src/sage/interfaces/polymake.py", line 2187, in sage.interfaces.polymake.PolymakeExpect._eval_line
Failed example:
    c.N_VERTICES                      # optional - polymake
Expected:
    32768
Got:
    Member function 'N_VERTICES' of 1 object
**********************************************************************

[mkoeppe]

Branch: u/mkoeppe/update_polymake_to_4_5

[mkoeppe]

Commit: bcfe163

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

8f1b816	build/pkgs/perl_cpan_polymake_prereq/distros: Add info for Term::ReadKey
654e6ea	build/pkgs/{perl_term_readline_gnu,polymake}: Change from experimental to optional
bcfe163	build/pkgs/polymake: Update to 4.5

[mkoeppe]

comment:7

Replying to @mkoeppe:

sage -t --random-seed=0 src/sage/interfaces/polymake.py
**********************************************************************
File "src/sage/interfaces/polymake.py", line 2187, in sage.interfaces.polymake.PolymakeExpect._eval_line
Failed example:
    c.N_VERTICES                      # optional - polymake
Expected:
    32768
Got:
    Member function 'N_VERTICES' of 1 object
**********************************************************************

This one (with the deprecated pexpect-based interface) we already saw in the previous upgrade ticket, #27745 comment:69

[tscrim]

comment:8

If we are having a test failure like that, then we can't upgrade this to an optional. Or is it still marked as # known bug?

[mkoeppe]

comment:9

Right, we had marked some of the failing or non-robust tests optional - polymake_expect.
I'll mark the ones that failed this time in the same way.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9d2674b

src/sage/interfaces/polymake.py: Mark some more doctests '# optional - polymake_expect'

[sagetrac-git]

Changed commit from bcfe163 to 9d2674b

[tscrim]

comment:11

Okay, that will be good.

The only other thing I am not sure about with making this optional is the perl dependencies. It should be okay, but I feel like we should just double check on sage-devel about this.

[mkoeppe]

Dependencies: #31163

[sagetrac-git]

Changed commit from 9d2674b to 8c8e1c4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2576f86	build/make/Makefile.in: If a script package has no spkg-install, run "sage -info" and exit with error
feb8de7	build/pkgs/: Remove spkg-install scripts for dummy script packages
8f782c0	.github/workflows/tox-{optional,experimental}.yml: Do not try to test dummy script packages
4b292be	build/pkgs/perl_mongodb/spkg-install: Remove
a7b6352	build/bin/sage-spkg-info: Fix display of system packages
e65b309	bootstrap: Do not provide ./configure --enable-SPKG options for dummy optional packages
b485d46	m4/sage_spkg_collect.m4: Do not advertise dummy optional packages as installable
8c8e1c4	Merge #31163

[mkoeppe]

comment:14

I'd say the Perl dependencies are just like other dummy packages that we have that can only be installed using system packages. For example: pandoc

I've now merged #31163, which gives better system package info when someone ignores the advice issued by configure and attempts to install perl_cpan_polymake_prereq (directly or as a dependency of polymake).

[sagetrac-git]

Changed commit from 8c8e1c4 to 015b899

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

015b899

build/bin/sage-print-system-package-command: Handle cpan

[tscrim]

comment:16

Okay, then let it be so.

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:17

Thank you!

[vbraun]

Changed branch from u/mkoeppe/update_polymake_to_4_5 to 015b899

[dimpase]

comment:19

On #31527 I found that jupymake must be installed if polymake is, so dependencies aren't set right here.

[dimpase]

Changed commit from 015b899 to none