Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: lrslib 071b and polymake 4.4, deprecate PolymakeExpect #27745

Closed
mkoeppe opened this issue Apr 29, 2019 · 174 comments
Closed

Upgrade: lrslib 071b and polymake 4.4, deprecate PolymakeExpect #27745

mkoeppe opened this issue Apr 29, 2019 · 174 comments
Labels
c: packages: optional p: critical / 2 t: enhancement
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 29, 2019

lrslib is now at 071b.

polymake 4.4 tarball: https://polymake.org/lib/exe/fetch.php/download/polymake-4.4-minimal.tar.bz2

Polymake 4.4 was released 2021-05-18, we are several releases behind:

For updated instructions regarding the Perl prerequisites, see #31830. Let's keep that a separate ticket.

CC: @slel @yuan-zhou @kliem @videlec @kiwifb @dimpase @simon-king-jena

Component: packages: optional

Keywords: upgrade, lrslib

Author: Matthias Koeppe, Jonathan Kliem, Travis Scrimshaw

Branch/Commit: ff69f28

Reviewer: Thierry Monteil, Matthias Koeppe, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27745
@mkoeppe mkoeppe added this to the sage-8.8 milestone Apr 29, 2019
@mkoeppe

This comment has been minimized.

Sign in to view
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:2

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@mkoeppe
Copy link
Member Author

mkoeppe commented May 1, 2020

comment:3

Moving some tickets to 9.2. This is not a promise that I will be working on them.

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 1, 2020
@slel

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Aug 19, 2020

Changed keywords from none to upgrade, lrslib

@slel slel changed the title Upgrade lrslib to 7.0 Upgrade: lrslib 7.1 Aug 19, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 24, 2021

comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade: lrslib 7.1 Upgrade: lrslib 071a May 17, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

Branch: u/mkoeppe/upgrade__lrslib_071a

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

Commit: 6f34801

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

New commits:

6f34801build/pkgs/lrslib: Update lrslib to 071a+autotools-2021-05-17

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

comment:11

Various failures in ./sage -tp src/sage/game_theory/, needs work

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2021

comment:12

Does anyone already have patches to support lrslib 071a in the Sage library?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

a6ba760build/pkgs/lrslib/spkg-install.in: Remove LRS_QUIET - in 071a, it makes the output unusable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f6b4d50Merge tag '9.4.beta4' into t/27745/lrslib071a_polymake44_upgrade-27745
d77aceesage.game_theory: Switch to new lrsnash input format

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2021

Changed commit from aa028b7 to d77acee

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 14, 2021

comment:134

Ready for testing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2021

Changed commit from d77acee to 794cf6a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

794cf6abuild/pkgs/lrslib/spkg-configure.m4: Check for recent lrsnash

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5f32d2ebuild/pkgs/lrslib/: Update to 071b+autotools-2021-07-13

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2021

Changed commit from 794cf6a to 5f32d2e

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade: lrslib 071a and polymake 4.4, deprecate PolymakeExpect Upgrade: lrslib 071b and polymake 4.4, deprecate PolymakeExpect Jul 14, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 14, 2021

comment:138

Tests at https://github.com/mkoeppe/sage/actions/runs/1028577144, https://github.com/mkoeppe/sage/actions/runs/1028577149, https://github.com/mkoeppe/sage/actions/runs/1028577148

@tscrim
Copy link
Collaborator

tscrim commented Jul 14, 2021

Changed commit from 5f32d2e to ff69f28

@tscrim
Copy link
Collaborator

tscrim commented Jul 14, 2021

comment:139

Thank you for fixing that. I have made a few changes to the parser file so that it tests the new format. I also added it to the doc and did some very slight cleanup of that file too.

I am happy with everything. If my changes are good, then we can set this to a positive review. All tests pass for me.

New commits:

53c7b65Rewriting doctests to test the new format.
95ce6dfAdding the game theory parser to the documentation.
ff69f28Some last little fixes.

@tscrim
Copy link
Collaborator

tscrim commented Jul 14, 2021

Changed branch from u/mkoeppe/lrslib071a_polymake44_upgrade-27745 to u/tscrim/upgrade_lrslib_polymake-27745

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 14, 2021

Changed author from Matthias Koeppe, Jonathan Kliem to Matthias Koeppe, Jonathan Kliem, Travis Scrimshaw

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 14, 2021

comment:140

Thanks, LGTM.

For the record, I tested the spkg-configure.m4 using tox -e docker-ubuntu-xenial-maximal -- config.status (correctly does not accept lrslib) and tox -e docker-ubuntu-bionic-maximal -- config.status (correctly accepts lrslib).

@vbraun
Copy link
Member

vbraun commented Jul 23, 2021

Changed branch from u/tscrim/upgrade_lrslib_polymake-27745 to ff69f28

@vbraun vbraun closed this as completed in dfa9663 Jul 23, 2021
This was referenced Jul 24, 2021
Closed
Closed
Closed
@videlec videlec mentioned this issue Jul 31, 2021
Closed
@mkoeppe mkoeppe mentioned this issue Jun 13, 2021
Closed
@kliem kliem mentioned this issue Jul 23, 2021
Closed
This was referenced Oct 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
10 participants
@embray @vbraun @dimpase @tscrim @slel @sheerluck @mkoeppe @simon-king-jena @antonio-rojas @kliem