polymake: Upgrade to 4.7, remove deprecated Polymake_expect interface

[mkoeppe]

https://polymake.org/doku.php/news/release_4_7

PolymakeExpect was deprecated in #27745

Previous updates: #27745, #33251

CC: @jplab @kliem @videlec @dimpase @tscrim

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: cfe0108

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34222

[mkoeppe]

Branch: u/mkoeppe/polymake__upgrade_to_4_7

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: cc7c589

[mkoeppe]

comment:2

One failure:

sage -t --random-seed=43175074141886505163444231207851145652 src/sage/interfaces/polymake.py
**********************************************************************
File "src/sage/interfaces/polymake.py", line 787, in sage.interfaces.polymake.PolymakeAbstract.application
Failed example:
    q.VERY_AMPLE                  # optional - polymake
Exception raised:
    Traceback (most recent call last):
      File "/Users/mkoeppe/s/sage/sage-rebasing/src/sage/interfaces/interface.py", line 732, in __init__
        self._name = parent._create(value, name=name)
      File "/Users/mkoeppe/s/sage/sage-rebasing/src/sage/interfaces/polymake.py", line 550, in _create
        self.set(name, value)
      File "/Users/mkoeppe/s/sage/sage-rebasing/src/sage/interfaces/polymake.py", line 639, in set
        self.eval(cmd)
      File "/Users/mkoeppe/s/sage/sage-rebasing/src/sage/interfaces/polymake.py", line 2713, in eval
        raise PolymakeError(error)
    sage.interfaces.polymake.PolymakeError: no more rules available to compute 'VERY_AMPLE'

---

New commits:

cc7c589

build/pkgs/polymake: Upgrade to 4.7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0a8bdc9

build/pkgs/polymake: Upgrade to 4.7

[sagetrac-git]

Changed commit from cc7c589 to 0a8bdc9

[mkoeppe]

comment:6

Replying to @mkoeppe:

One failure:

Can't reproduce

[tscrim]

comment:8

After running make polymake, I am getting error messages of the form:

RuntimeError: runtime error with deprecated pexpect-based interface to polymake; please install jupymake

So I think we have a missed dependency. It might already be necessary, but this might be a good place to fix it.

[mkoeppe]

comment:9

That's when running doctests, or manual testing?

[mkoeppe]

comment:10

In any case, the PolymakeExpect was deprecated in #27745, more than a year ago, so I think we can just remove it

[tscrim]

comment:11

Running the doctests. I am just installing the jupymake.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c5bd052

src/sage/interfaces/polymake.py: Remove deprecated Polymake_expect

[sagetrac-git]

Changed commit from 0a8bdc9 to c5bd052

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1927882

Replace '# optional - polymake' with '# optional - jupymake'

[sagetrac-git]

Changed commit from c5bd052 to 1927882

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cfe0108

build/pkgs/polymake/SPKG.rst: Update info on jupymake

[sagetrac-git]

Changed commit from 1927882 to cfe0108

[tscrim]

comment:16

Overall LGTM. Is there some reason why we don't explicitly make polymake depend on jupymake? Are there things we could call without jupymake?

[mkoeppe]

comment:19

Replying to @tscrim:

Overall LGTM. Is there some reason why we don't explicitly make polymake depend on jupymake? Are there things we could call without jupymake?

See #27745 comment:60

[tscrim]

comment:20

Same thought, same comment. haha

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:22

Thanks!

[vbraun]

Changed branch from u/mkoeppe/polymake__upgrade_to_4_7 to cfe0108