Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate direct use of os.getenv in sage.interfaces #33405

Open
mkoeppe opened this issue Feb 23, 2022 · 5 comments
Open

Eliminate direct use of os.getenv in sage.interfaces #33405

mkoeppe opened this issue Feb 23, 2022 · 5 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 23, 2022

... as shown by git grep getenv, environment variables such as SAGE_MACAULAY2_COMMAND are checked.

These should go through variables defined in sage.env (and perhaps through sage.feature, Executable.absolute_filename(), #31296) so that they can be configured using sage_conf as well.

(see also #32867 comment:31 to #32867 comment:36)

See also: #32957 Replace have_program usage by Features

CC: @kiwifb @antonio-rojas @fchapoton @orlitzky @tornaria @dimpase

Component: refactoring

Issue created by migration from https://trac.sagemath.org/ticket/33405

@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 23, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2022

Dependencies: #31296

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant