FriCAS spkg-configure and Feature #35838

dimpase · 2023-06-26T16:53:12Z

As FriCAS is only used as an executable, this is straightforward; quite a number of systems has Fricas 1.3.8, so this is useful, too.

The FriCAS pexpect interface now uses the new Executable feature to determine the absolute pathname of the fricas executable (unless executed remotely).
This is made possible by a simple refactor of the sage.interfaces.expect.Expect class: Computing the effective command line is no longer done in set_server_and_command (called by __init__); it is delayed until an interface is started and needs the command line.

Fixes accept fricas from the system #35837
Fixes Feature for fricas #33575

Dependencies: The changes in sage.interfaces outside of .expect and .fricas are all from the following PR and do not need review.

Depends on sage.interfaces: Update # needs #36656 (merged here)

mkoeppe · 2023-06-27T16:26:40Z

The doctests marked # optional - fricas won't be run unless you also do #33575

build/pkgs/fricas/distros/gentoo.txt

dimpase · 2023-06-27T20:46:59Z

FriCAS people say using SBCL instead of ECL gives 3 to 4 times faster system.

…

On Tue, 27 Jun 2023, 21:45 François Bissey, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build/pkgs/fricas/distros/gentoo.txt <#35838 (comment)>: > @@ -0,0 +1 @@ +sci-mathematics/fricas[sbcl] Why do you impose it to be build with sbcl. Sure it is probably the fastest lisp around, but is there a specific reason that you need to have it? — Reply to this email directly, view it on GitHub <#35838 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXYHF5OKNYACSAM6BVC6LXNNA47ANCNFSM6AAAAAAZUN3DRE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

kiwifb · 2023-06-27T20:58:34Z

I am not saying to make it ECL, I am saying that lips user on Gentoo make their own choices unless there is a technical reason (as in a breaking reason) to do so. If they are interested in speed they will make that choice themselves.

dimpase · 2023-06-29T16:26:00Z

The doctests marked # optional - fricas won't be run unless you also do #33575

This looks quite heavy-handed. Why can't this be done at ./configure time? What's the magic done by building fricas spkg so that #33575 is not needed?

mkoeppe · 2023-06-29T16:41:41Z

When you build the fricas spkg, there will be an installation record that is found by sage.misc.packages.

This is a Sage-the-distribution-specific mechanism that we want to get rid of altogether (see #35856), for the benefit of downstream packagers and also for the pip-installed setting. See also #35858

dimpase · 2023-06-30T15:48:01Z

OK, I'm trying now the patch https://github.com/sagemath/sagetrac-mirror/commit/73ad696e35101a24c6c5b03adb518fad8ef3a91b.diff from #33575 (it applies with a fizz)

dimpase · 2023-06-30T18:14:22Z

OK, feature seems to be implemented now, please have a look

mkoeppe · 2023-06-30T18:34:06Z

build/pkgs/fricas/spkg-configure.m4

@@ -0,0 +1,16 @@
+SAGE_SPKG_CONFIGURE(
+    [fricas], [
+        AC_CACHE_CHECK([for FriCAS >= 1.3.8], [ac_cv_path_FRICAS], [


the indentation is a bit wild

mkoeppe · 2023-06-30T18:37:35Z

Has using system fricas been tested on more than 1 machine?

dimpase · 2023-06-30T22:19:28Z

Has using system fricas been tested on more than 1 machine?

on 2 different machines, 3 different configurations (using ECL as well as using SBCL as lisp compiler)

mkoeppe · 2023-06-30T22:41:47Z

Build&Test fails with lots of errors originating from the feature thing

dimpase · 2023-06-30T23:19:05Z

works for me locally, it's probably unrelated. unless these errors come from unavailable fricas.

…

On Fri, 30 Jun 2023, 23:41 Matthias Köppe, ***@***.***> wrote: Build&Test fails with lots of errors originating from the feature thing — Reply to this email directly, view it on GitHub <#35838 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXYHDZ6U6SSB2HLWPUGITXN5I3NANCNFSM6AAAAAAZUN3DRE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

mkoeppe · 2023-07-01T00:32:15Z

Yes, in the test run on GH Actions there is no FriCAS because it's an optional package...

dimpase · 2023-07-01T08:42:06Z

Build&Test fails with lots of errors originating from the feature thing

well, indeed - I suppose it's due to #33575 pointing to an outdated design, compared to e.g. what's in
src/sage/features/csdp.py

Another potential problem is is_FriCASElement - not sure what should come to replace it.

mkoeppe · 2023-07-01T16:11:29Z

Another potential problem is is_FriCASElement - not sure what should come to replace it.

sage.interfaces.abc

mkoeppe · 2023-07-01T16:42:16Z

I'll take a look what needs to be fixed in the feature definition later today.

dimpase · 2023-07-01T16:49:05Z

I'll take a look what needs to be fixed in the feature definition later today.

I'm actually working on this now. I'll post an update in an hour or two

dimpase · 2023-07-01T17:19:34Z

here is a non-working update. I'm lost at what options are supposed to be there.

sage.features an unpleasantly fragile kludge. Is it supposed to test whether pexpect FriCAS interface works?
Whether fricas executable is there? Really, no idea, no docs...

...
FileNotFoundError: [Errno 2] No such file or directory: 'fricas -nosman'

----------------------------------------------------------------------
sage -t --random-seed=195934185104556495832583672009163086833 src/sage/features/fricas.py  # FileNotFoundError in doctesting framework

mkoeppe · 2023-07-01T17:37:19Z

The documentation is being added in this PR, no?

src/sage/features/fricas.py

dimpase · 2023-07-02T08:09:41Z

Do we need _install_hints for FriCAS ? It's not like the other packages for which it's provided, one can install it from Sage.

dimpase · 2023-07-02T08:16:14Z

If FriCAS is not available (I just remove the executable), I get doctest errors like

File "src/sage/interfaces/fricas.py", line 899, in sage.interfaces.fricas.FriCAS.__reduce__
Failed example:
    FriCAS().__reduce__()
Exception raised:
    Traceback (most recent call last):
      File "/mnt/opt/Sage/sage-dev/src/sage/doctest/forker.py", line 696, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/opt/Sage/sage-dev/src/sage/doctest/forker.py", line 1106, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.fricas.FriCAS.__reduce__[0]>", line 1, in <module>
        FriCAS().__reduce__()
        ^^^^^^^^
      File "sage/misc/lazy_import.pyx", line 404, in sage.misc.lazy_import.LazyImport.__call__
        sage: is_prime(12) == my_isprime(12)
      File "sage/misc/lazy_import.pyx", line 225, in sage.misc.lazy_import.LazyImport.get_object
        return self._get_object()
      File "sage/misc/lazy_import.pyx", line 261, in sage.misc.lazy_import.LazyImport._get_object
        try:
      File "/mnt/opt/Sage/sage-dev/src/sage/interfaces/fricas.py", line 2134, in <module>
        fricas = FriCAS()
                 ^^^^^^^^
      File "/mnt/opt/Sage/sage-dev/src/sage/interfaces/fricas.py", line 293, in __init__
        FriCAS().require()
      File "/mnt/opt/Sage/sage-dev/src/sage/features/__init__.py", line 243, in require
        raise FeatureNotPresentError(self, presence.reason, presence.resolution)
    sage.features.FeatureNotPresentError: fricas is not available.
    Executable 'fricas' not found on PATH.
    To install fricas using the gentoo package manager, you can try to run:
    !sudo emerge sci-mathematics/fricas
    To install fricas using the Sage package manager, you can try to run:
      !sage -i fricas
    No equivalent system packages for pip are known to Sage.
    Further installation instructions might be available at https://fricas.github.io.

no idea what's wrong. Could it be due to ./configure --enable-fricas=yes ?

The branch seems to work (modulo a number of maths doctest errors) if FriCAS is available.

This is needed as SBCL-built FriCAS does not output anything if )quit is passed via -eval option, as opposed to ECL-built FriCAS.

…andle Executable

…erances; cf. sagemath#36631

…examples

github-actions · 2023-11-22T15:42:59Z

Documentation preview for this PR (built with commit 870fa22; changes) is ready! 🎉

mkoeppe · 2023-11-22T16:29:07Z

Usually not a good idea to do a rebase that includes the dependency PR.

dimpase · 2023-11-22T23:16:31Z

All good, it seems.
Tested with system fricas built with sbcl, as well as fricas built with ECL (both on Gentoo - @orlitzky )
Also tests fine without fricas.

I can't officially review this, so, please...

dimpase · 2023-11-25T10:17:11Z

@mantepse - this allows using system-wide FriCAS.

As FriCAS is only used as an executable, this is straightforward; quite a number of systems has Fricas 1.3.8, so this is useful, too. The FriCAS pexpect interface now uses the new `Executable` feature to determine the absolute pathname of the fricas executable (unless executed remotely). This is made possible by a simple refactor of the `sage.interfaces.expect.Expect` class: Computing the effective command line is no longer done in `set_server_and_command` (called by `__init__`); it is delayed until an interface is started and needs the command line. - Fixes sagemath#35837 - Fixes sagemath#33575 Dependencies: The changes in `sage.interfaces` outside of `.expect` and `.fricas` are all from the following PR and do not need review. - Depends on sagemath#36656 (merged here) URL: sagemath#35838 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, François Bissey, Matthias Köppe

dimpase · 2024-01-09T19:45:28Z

fricas 1.3.10 is meanwhile out.

dimpase added c: build: configure s: needs review labels Jun 26, 2023

dimpase requested review from mkoeppe and kiwifb June 26, 2023 16:53

kiwifb reviewed Jun 27, 2023

View reviewed changes

build/pkgs/fricas/distros/gentoo.txt Outdated Show resolved Hide resolved

mkoeppe reviewed Jun 30, 2023

View reviewed changes

dimpase force-pushed the fricas_spkg_config branch from 38d728e to 47073ef Compare July 1, 2023 17:15

mkoeppe reviewed Jul 1, 2023

View reviewed changes

src/sage/features/fricas.py Outdated Show resolved Hide resolved

dimpase force-pushed the fricas_spkg_config branch from 47073ef to f90bbce Compare July 1, 2023 21:20

dimpase force-pushed the fricas_spkg_config branch from 5eaf9af to 5adc1b7 Compare July 2, 2023 08:44

Matthias Koeppe and others added 16 commits November 22, 2023 15:05

Add # needs

20b960d

Update # needs

cd3543c

more distros for fricas

f4999b0

spkg-configure for fricas

21ab2c7

remove debugging echo

467eff9

do not insist on sbcl

6ed8cb0

modify the way to send )quit to fricas

2fd6098

This is needed as SBCL-built FriCAS does not output anything if )quit is passed via -eval option, as opposed to ECL-built FriCAS.

updated design of feature

ba63341

better string to match (for various lisps)

77b1e7a

src/sage/interfaces/fricas.py: Use file-level doctest tag

43c85c8

sage.interfaces.expect: Delay construction of command to first use, h…

9ec6b94

…andle Executable

src/sage/interfaces/fricas.py: Use the FriCAS feature less eagerly

26e2e58

sage.interfaces.expect: Fix up ulimit

b474f0e

sage.interfaces.expect: Update doctest output

256bb8c

src/sage/interfaces/fricas.py: Do not rely on '# tol' for complex tol…

ace41e4

…erances; cf. sagemath#36631

src/sage/functions/special.py: Use 'abs tol' instead of 'tol' in two …

870fa22

…examples

dimpase force-pushed the fricas_spkg_config branch from 044f6c1 to 870fa22 Compare November 22, 2023 15:05

mkoeppe approved these changes Nov 22, 2023

View reviewed changes

mkoeppe added s: positive review and removed s: needs review labels Nov 22, 2023

vbraun merged commit 9c4fc77 into sagemath:develop Dec 6, 2023
34 of 51 checks passed

mkoeppe added this to the sage-10.3 milestone Dec 6, 2023

github-actions bot removed the s: positive review label Dec 6, 2023

dimpase deleted the fricas_spkg_config branch December 12, 2023 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FriCAS spkg-configure and Feature #35838

FriCAS spkg-configure and Feature #35838

dimpase commented Jun 26, 2023 •

edited by mkoeppe

Loading

mkoeppe commented Jun 27, 2023

dimpase commented Jun 27, 2023 via email

kiwifb commented Jun 27, 2023

dimpase commented Jun 29, 2023

mkoeppe commented Jun 29, 2023 •

edited

Loading

dimpase commented Jun 30, 2023

dimpase commented Jun 30, 2023

mkoeppe Jun 30, 2023

mkoeppe commented Jun 30, 2023

dimpase commented Jun 30, 2023

mkoeppe commented Jun 30, 2023

dimpase commented Jun 30, 2023 via email

mkoeppe commented Jul 1, 2023

dimpase commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

dimpase commented Jul 1, 2023

dimpase commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

dimpase commented Jul 2, 2023

dimpase commented Jul 2, 2023

github-actions bot commented Nov 22, 2023

mkoeppe commented Nov 22, 2023

dimpase commented Nov 22, 2023

dimpase commented Nov 25, 2023

dimpase commented Jan 9, 2024

FriCAS spkg-configure and Feature #35838

FriCAS spkg-configure and Feature #35838

Conversation

dimpase commented Jun 26, 2023 • edited by mkoeppe Loading

mkoeppe commented Jun 27, 2023

dimpase commented Jun 27, 2023 via email

kiwifb commented Jun 27, 2023

dimpase commented Jun 29, 2023

mkoeppe commented Jun 29, 2023 • edited Loading

dimpase commented Jun 30, 2023

dimpase commented Jun 30, 2023

mkoeppe Jun 30, 2023

Choose a reason for hiding this comment

mkoeppe commented Jun 30, 2023

dimpase commented Jun 30, 2023

mkoeppe commented Jun 30, 2023

dimpase commented Jun 30, 2023 via email

mkoeppe commented Jul 1, 2023

dimpase commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

dimpase commented Jul 1, 2023

dimpase commented Jul 1, 2023

mkoeppe commented Jul 1, 2023

dimpase commented Jul 2, 2023

dimpase commented Jul 2, 2023

github-actions bot commented Nov 22, 2023

mkoeppe commented Nov 22, 2023

dimpase commented Nov 22, 2023

dimpase commented Nov 25, 2023

dimpase commented Jan 9, 2024

dimpase commented Jun 26, 2023 •

edited by mkoeppe

Loading

mkoeppe commented Jun 29, 2023 •

edited

Loading