Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyhedralComplex.plot(explosion_factor=1) #33596

Closed
mkoeppe opened this issue Mar 30, 2022 · 46 comments
Closed

PolyhedralComplex.plot(explosion_factor=1) #33596

mkoeppe opened this issue Mar 30, 2022 · 46 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 30, 2022

CC: @yuan-zhou @jplab

Component: graphics

Author: Matthias Koeppe, Yuan Zhou

Branch/Commit: e8ec0eb

Reviewer: Yuan Zhou, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33596

@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 30, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2022

New commits:

42db852src/sage/geometry/polyhedral_complex.py (exploded_rainbow_plot, PolyhedralComplex.plot): New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2022

Commit: 42db852

@mkoeppe mkoeppe changed the title PolyhedralComplex.plot_exploded PolyhedralComplex.plot(explosion_factor=1) Aug 5, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from 42db852 to 1028bb4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1028bb4src/sage/geometry/polyhedral_complex.py: Add documentation

@yuan-zhou
Copy link

comment:6

It is a very cool feature!

The plot method should include such an example which is decorated with # optional - sage.plot where the explosion_factor is nonzero.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9eebc32src/sage/geometry/polyhedral_complex.py: Expand example of plot method

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from 1028bb4 to 9eebc32

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2022

comment:8

Probably not so great that the exploded plot uses rainbow colors implicitly but the non-exploded plot doesn't

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from 9eebc32 to b0ed0a7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b0ed0a7src/sage/geometry/polyhedral_complex.py (exploded_rainbow_plot): Accepts dicts for sticky_vertices, sticky_center

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from b0ed0a7 to e1d43a9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e1d43a9src/sage/geometry/polyhedral_complex.py: Change to a centrally symmetric example

@yuan-zhou
Copy link

comment:11

Can use rainbow color plot when explosion_factor=0 is provided, and use normal plot when explosion_factor is not specified.
Replying to @mkoeppe:

Probably not so great that the exploded plot uses rainbow colors implicitly but the non-exploded plot doesn't

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

3d84635src/sage/geometry/polyhedral_complex.py (exploded_plot): Rename from exploded_rainbow_plot, handle color='rainbow'

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from e1d43a9 to 3d84635

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

85cb04esrc/sage/geometry/polyhedral_complex.py (exploded_plot): Do not set alpha=0.5 by default

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from 3d84635 to 85cb04e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Changed commit from 85cb04e to 568b027

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

568b027src/sage/geometry/polyhedral_complex.py (exploded_plot): Use same default for point size as Polyhedron.plot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from 568b027 to efc9455

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

efc9455src/sage/geometry/polyhedral_complex.py (PolyhedralComplex.plot): Handle color='rainbow' in non-exploded plots too

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from efc9455 to f0321e5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

comment:21

Try now. explosion_factor=0.3 is better in this case

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

cc0a47esrc/sage/geometry/polyhedral_complex.py (exploded_plot): Fix doc of sticky_center

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from f0321e5 to cc0a47e

@yuan-zhou
Copy link

@yuan-zhou
Copy link

comment:25

Add examples of 3d plots.


New commits:

c5a8200src/sage/geometry/polyhedral_complex.py (plot): Add 3d plot examples

@yuan-zhou
Copy link

Changed commit from cc0a47e to c5a8200

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2b9decfsrc/sage/geometry/polyhedral_complex.py (plot): Describe exploded_plot keyword arguments in the docstring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from c5a8200 to 2b9decf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

Changed author from Matthias Koeppe to Matthias Koeppe, Yuan Zhou

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b064146src/sage/geometry/polyhedral_complex.py (plot): Add 3d plot examples (fixup)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from 2b9decf to b064146

@yuan-zhou
Copy link

comment:29

Since points are plotted before polyhedra, will they be covered by the polyhedra? Shall we either use zorder or reverse the plotting order to make vertices visible?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

comment:30

good idea to plot them in the reverse order

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e8ec0ebsrc/sage/geometry/polyhedral_complex.py (exploded_plot): Plot polyhedra first, lines next and points last.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from b064146 to e8ec0eb

@yuan-zhou
Copy link

Reviewer: Yuan Zhou, Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

comment:34

Thanks for adding these great examples and for the review

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/yzh/polyhedralcomplex_plot_exploded to e8ec0eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants