-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer.json for development with VS Code in a Docker container #33671
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: #29536 |
Author: Tobias Diez |
Commit: |
Changed dependencies from #29536 to none |
Branch: public/build/devcontainer |
comment:5
A basic devcontainer definition is now added for ubuntu systems. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:9
Thanks! That's a beginning. Why do you not use the full build ( |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Changed author from Tobias Diez to Tobias Diez, Matthias Koeppe |
Dependencies: #33825 |
comment:14
Replying to @mkoeppe:
I didn't saw the point in that. In contrast to gitpod you don't know which version of sage the developer will use in the devcontainer, especially since devcontainer are cached by vscode until they are manually rebuild. |
comment:15
You also don't know that on gitpod, as I've explained in #33113 comment:18 |
comment:297
Replying to @tobiasdiez:
I've set the scope of the ticket to be actionable. Work on codespaces is not actionable for me. You want to support them, you do the work on the follow-up ticket. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:299
Replying to @tobiasdiez:
It's there as preparation for the following improvement (which is waiting for #29536):
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:302
Replying to @tobiasdiez:
Thanks for catching this. Done now. |
comment:304
Simple renaming. Positive again. |
Changed branch from public/build/devcontainer to |
https://code.visualstudio.com/docs/remote/containers
We add two new sections in the developer's guide:
https://47f8b984ef964a5aa34147393fbdc32e0dde88ad--sagemath-tobias.netlify.app/developer/portability_testing.html#using-our-pre-built-docker-images-published-on-ghcr-io
We also set up devcontainer configurations for the CoCalc and computop/sage Docker images, as well as downstream distribution packaging of Sage.
Tested
devcontainer.json
ofportability-ubuntu-jammy-standard
: builds well; runs welldevelop-docker-computop
: builds well; runs welldownstream-docker-cocalc
: builds well; runs well (except machines with the issue Do not require AVX when building with SAGE_FAT_BINARY #32434)downstream-docker-computop
: builds well; runs welldownstream-archlinux-latest
: builds well; runs welldownstream-conda-forge-latest
: builds well; runs wellFollow-ups:
downstream-*
for more distributions (generate withtox
from the info intox.ini, use
_sagemath` package)develop-conda-forge-src-environment-dev
(https://doc.sagemath.org/html/en/installation/conda.html#using-conda-to-provide-all-dependencies-for-the-sage-library-experimental, similar to our gitpod configuration)portability-debian-buster-i386-standard
and fix itdevelop-docker-cocalc
(was: builds well (after increasing disk image space on the Docker daemon); fails to run)portability-centos-7-devtoolset-gcc_11-standard
(was: builds well; fails to run (exactly the same on WSL))downstream-docker-sagemath
(after Update docker build #34242)portability-Dockerfile
as explained in comment:299Depends on #33873
Depends on #34352
CC: @tobiasdiez @dimpase @williamstein @culler @saraedum @kwankyu
Component: user interface
Author: Tobias Diez, Matthias Koeppe, Kwankyu Lee
Branch/Commit:
4affef2
Reviewer: Kwankyu Lee, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/33671
The text was updated successfully, but these errors were encountered: