Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.devcontainer/portability-ubuntu-jammy-standard fails in GitHub Codespaces #34403

Closed
mkoeppe opened this issue Aug 21, 2022 · 5 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 21, 2022

Follow-up from

ISSUE: .devcontainer/portability-ubuntu-jammy-standard fails in GitHub Codespaces as reported first in

#33671 comment:271

TEST: github codespaces uses the devcontainer CLI so you probably can reproduce this issue locally using ​https://code.visualstudio.com/docs/remote/devcontainer-cli.

  • Install devcontainer CLI: npm install -g @devcontainers/cli
  • Create and run devcontainer: devcontainer up --workspace-folder . in sage source tree

Depends on #33671

CC: @tobiasdiez

Component: user interface

Issue created by migration from https://trac.sagemath.org/ticket/34403

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 21, 2022
@kwankyu

This comment has been minimized.

@kwankyu kwankyu changed the title GitHub Codespaces .devcontainer/portability-ubuntu-jammy-standard fails in GitHub Codespaces Aug 22, 2022
@kwankyu

This comment has been minimized.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 22, 2022

comment:3

I did the test locally. But there is no problem. Here are the first and last few lines:

$ devcontainer up  --workspace-folder ./
[28 ms] @devcontainers/cli 0.12.1.
[324 ms] Start: Run: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /Users/kwankyu/GitHub/sage-dev/.devcontainer/portability-Dockerfile -t vsc-sage-dev-bcfc2943513139536df2e9cd46be541d --build-arg SYSTEM_FACTOR=ubuntu-jammy --build-arg PACKAGE_FACTOR=standard --build-arg DOCKER_TARGET=with-targets --build-arg DOCKER_TAG=dev /Users/kwankyu/GitHub/sage-dev/.devcontainer
[+] Building 0.7s (6/6) FINISHED                                                
 => [internal] load build definition from portability-Dockerfile           0.0s
 => => transferring dockerfile: 44B                                        0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 2B                                            0.0s
 => [internal] load metadata for ghcr.io/sagemath/sage/sage-docker-ubuntu  0.6s
 => CACHED [1/1] FROM ghcr.io/sagemath/sage/sage-docker-ubuntu-jammy-stan  0.0s
 => exporting to image                                                     0.0s
 => => exporting layers                                                    0.0s
 => => writing image sha256:05758e709ba75d931c0f0db9d148400bc5c62cb0d8e98  0.0s
 => => naming to docker.io/library/vsc-sage-dev-bcfc2943513139536df2e9cd4  0.0s
 => exporting cache                                                        0.0s
 => => preparing build cache for export                                    0.0s
[1543 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/Users/kwankyu/GitHub/sage-dev,target=/workspaces/sage-dev,consistency=cached -l devcontainer.local_folder=/Users/kwankyu/GitHub/sage-dev -e MAKE=make -j4 --entrypoint /bin/sh vsc-sage-dev-bcfc2943513139536df2e9cd46be541d -c echo Container started
Container started
Running the onCreateCommand from devcontainer.json...

Hit:1 http://archive.ubuntu.com/ubuntu jammy InRelease                         
Get:2 http://security.ubuntu.com/ubuntu jammy-security InRelease [110 kB]  
...
...
...
[sage_setup-9.7.beta8] installing. Log file: /workspaces/sage-dev/logs/pkgs/sage_setup-9.7.beta8.log
  [pytest] successfully installed.
  [sage_conf-9.7.beta8] successfully installed.
  [sage_setup-9.7.beta8] successfully installed.
make --no-print-directory sagelib-SAGE_VENV-no-deps
[sagelib-9.7.beta8] installing. Log file: /workspaces/sage-dev/logs/pkgs/sagelib-9.7.beta8.log
  [sagelib-9.7.beta8] successfully installed.
make --no-print-directory sage_docbuild-SAGE_VENV-no-deps
[sage_docbuild-9.7.beta8] installing. Log file: /workspaces/sage-dev/logs/pkgs/sage_docbuild-9.7.beta8.log
  [sage_docbuild-9.7.beta8] successfully installed.
make[2]: Leaving directory '/workspaces/sage-dev/build/make'

real	3m26.213s
user	0m32.446s
sys	0m21.044s
SAGE_CHECK=warn, so scanning the log files. This may take a few seconds.

* package:         openssl-3.0.5
  last build time: Aug 16 01:27
  log file:        /workspaces/sage-dev/logs/pkgs/openssl-3.0.5.log
Sage build/upgrade complete!
make[1]: Leaving directory '/workspaces/sage-dev'

{"outcome":"success","containerId":"b3afbba8327e41e1e5fd2fa2c6e89b5773d6db34aa20eb5a5a1ae80afc209b47","remoteUser":"root","remoteWorkspaceFolder":"/workspaces/sage-dev"}

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 10, 2022

comment:5

Looks like codespaces is now available to all

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 25, 2023

Works for me. One needs an 8-core or 16-core configuration so that there is enough disk space. I'm adding this detail in #36954.

@mkoeppe mkoeppe closed this as completed Dec 25, 2023
@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants