-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions: Split ci-macos.yml out from tox.yml #33788
Comments
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:5
I think it makes sense to have all them all together in one workflow. Especially with your idea to use stages, it makes sense to have all everything in one workflow since then you can easily wait on previous stages before running stages that run os-unspecific things (like running tests) on the artifacts of the previous stage. In principle, there are also github actions that enable one to wait on other workflows, but they are pretty unreliable in my experience. If its only for the overview, I would suggest to use the recently introduced feature to generate job summaries to automatically generate the portability report: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ |
comment:6
The runs for different OSes do not need to wait for each other for anything |
comment:7
The I feel like it would be helpful to have a general big picture for how to structure the workflows instead of moving them back and forth in the coming months. |
comment:8
I'm the one who monitors these workflow runs when releases are made, so organizing it for my convenience should be a good enough reason. |
comment:9
Replying to @tobiasdiez:
Counting green checkmarks is not what takes the time. It's looking at the logs |
comment:10
Replying to @mkoeppe:
You can put in the markdown overview whatever you want, for example the summary of what test failed or at what stage the tests failed etc. |
comment:11
It does look like a nice feature, but I don't plan to work on creating such a report. |
comment:14
Let's get this in please. |
This comment has been minimized.
This comment has been minimized.
comment:16
I presume it was tested on GH Actions. A link? |
comment:17
Testing in a branch with #34110 |
comment:18
lgtm |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/2611393906, https://github.com/mkoeppe/sage/actions/runs/2611393910 to Dima Pasechnik |
comment:19
Thank you! |
Changed branch from u/mkoeppe/gh_actions__split_ci_macos_yml_out_from_tox_yml to |
When preparing a portability report such as https://groups.google.com/g/sage-release/c/GOGWk66zaCQ/m/dBQww8WNAAAJ, I have found that the output of
tox.yml
has gotten too big to be comfortably inspected in one go.So we split out everything macOS into a separate workflow.
Preparation for #33062 and #32570
Depends on #34017
CC: @dimpase @kliem
Component: porting
Author: Matthias Koeppe
Branch/Commit:
aa25405
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33788
The text was updated successfully, but these errors were encountered: