-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy 1.23.x #34110
Comments
Branch: u/mkoeppe/numpy_1_23 |
Commit: |
Last 10 new commits:
|
Dependencies: #32423 |
comment:4
On
(regression from numpy 1.22.x). Reported at numpy/numpy#21920 |
comment:7
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits: |
This comment has been minimized.
This comment has been minimized.
comment:13
On OS X + various homebrew packages, I am getting two doctest failures:
|
comment:24
I see that this was already reported, please only set this to positive review when its fixed. |
comment:25
There's some strangeness in numpy. https://numpy.org/doc/stable/reference/generated/numpy.reciprocal.html clearly states "This function is not designed to work with integers", but numpy.linalg.norm happily passes integers to it, which causes this warning. |
comment:26
Actually not just a problem with integers.
(this is on macOS Intel) |
comment:27
This goes away if one installs the wheels provided by upstream (tested with |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:29
(This does not fix it; just backing out old workarounds before we add new ones.) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:31
(Also does not fix it.) |
comment:32
Upstream's macOS wheel configuration: https://github.com/numpy/numpy/blob/main/pyproject.toml#L90 |
comment:33
Using |
comment:34
As the fix in numpy/numpy#19926 suggests, this is compiler-specific. Using |
comment:35
It looks like the workaround in https://github.com/numpy/numpy/blob/main/numpy/core/src/umath/loops_unary_fp.dispatch.c.src#L105 relies on using But the logic there https://github.com/numpy/numpy/blob/main/numpy/distutils/ccompiler.py#L394 uses string comparison to decide whether the compiler is clang or not. |
comment:36
Indeed
fixes it. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:39
Works on both Intel and M2, so let's restore the positive review. (I haven't checked on an old version of OS X, though.) |
comment:40
Thanks! |
Changed reviewer from Dima Pasechnik to Dima Pasechnik, John Palmieri |
Changed branch from u/mkoeppe/numpy_1_23 to |
- https://scipy.github.io/devdocs/release.1.9.0.html (released) - scipy.optimize.milp (HiGHS MIP solver) - https://scipy.github.io/devdocs/release.1.9.0.html#scipy-switched- to-meson-as-its-build-system This ticket is also the target ticket for https://github.com/FFY00 /meson-python/blob/main/.github/workflows/ci-sage.yml Previous update: - sagemath#32423 Update numpy to 1.22.x, scipy 1.8.x, networkx 2.8.x See also: - sagemath#34110 numpy 1.23.x URL: https://trac.sagemath.org/34081 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik
(split out from #34081)
https://numpy.org/doc/stable/release/1.23.0-notes.html# (released)
The upgrade looks harmless.
1.23.x requires GCC >= 6.5. (This has been documented in numpy/numpy#22155 - to be included in 1.23.3.)
We set #34266 as a dependency, which increases our requirement from GCC >= 6.3 to GCC >= 8)
Previous update:
#32423 Update numpy to 1.22.x, scipy 1.8.x, networkx 2.8.x
Depends on #34266
CC: @sagetrac-tmonteil
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
03fad7d
Reviewer: Dima Pasechnik, John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/34110
The text was updated successfully, but these errors were encountered: