use Homebrew's primecount

[dimpase]

primecount is now on Homebrew, see kimwalisch/homebrew-primecount#1 (comment), so we can use it.

CC: @mkoeppe @jhpalmieri @GMS103

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 7bd0541

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33805

[dimpase]

comment:1

This does work on Intel macOS, not checked on M1.

[mkoeppe]

comment:2

If you remove the unnecessary homebrew-build-env change (https://groups.google.com/g/sage-devel/c/csifEQ0gJW8/m/toM0HCAYAAAJ), we can merge it

[GMS103]

comment:4

This is on Apple Silicon M1.

After brew install primecount and merging this ticket #33805 on top of SageMath 9.7.beta5:

• ./configure detects system primecount (primecount-7.4: using system package; SPKG will not be installed).

• make && make pytest && make ptestlong succeeds.

[dimpase]

comment:5

Replying to @mkoeppe:

If you remove the unnecessary homebrew-build-env change (https://groups.google.com/g/sage-devel/c/csifEQ0gJW8/m/toM0HCAYAAAJ), we can merge it

there is no harm in having it in homebrew-build-env. As I explained in the thread above, it's possible not to have it in the appropriate paths (or not in the right place in these paths).

[mkoeppe]

comment:6

Guillermo, could you please verify if it works without this branch (i.e., without the changes to .homebrew-build-env)?

[dimpase]

comment:7

this is a meaningless test, unless you really want to somehow (how?) make sure that primecount/sieve are installed and linked.

[mkoeppe]

comment:8

When you install these libraries, they are linked. Same as all other libraries except for those in keg-only packages. We do not have a list of all libraries in .homebrew-build-env - only those that need it because they are keg-only or need it as a specific workaround. Do you propose to change that and list all libraries in case someone has unlinked them?

[dimpase]

comment:9

they are only automatically linked if you don't already have them in your path somehow. I already mentioned this.

[mkoeppe]

comment:10

But this is not specific to primecount. Hence my question: Do you propose to handle all libraries in .homebrew-build-env in case someone has unlinked them?

[GMS103]

comment:11

Sorry, your discussion is beyond me.

In any case, same results for SageMath 9.7.beta5 without merging this ticket.

HTH

[mkoeppe]

comment:12

Replying to @GMS103:

same results for SageMath 9.7.beta5 without merging this ticket.

Thanks for testing! This means that we only need the new file build/pkgs/primecount/distros/homebrew.txt, but not the change to .homebrew-build-env.

[dimpase]

comment:13

Replying to @mkoeppe:

But this is not specific to primecount. Hence my question: Do you propose to handle all libraries in .homebrew-build-env in case someone has unlinked them?

why not, it's about 20 libraries, I gather.
Besides, it can be linked today, and no longer linked after brew update...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

74eda63	use Homebrew's primecount
82c8e7a	Revert "use Homebrew's primecount"
7bd0541	use Homebrew's primecount

[sagetrac-git]

Changed commit from 17ea4fa to 7bd0541

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from u/dimpase/config/homebrew/primecount to 7bd0541