Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle cleanup in src/sage/graphs/graph_generators.py #34074

Closed
dcoudert opened this issue Jun 25, 2022 · 11 comments
Closed

pycodestyle cleanup in src/sage/graphs/graph_generators.py #34074

dcoudert opened this issue Jun 25, 2022 · 11 comments
Labels
c: graph theory p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@dcoudert
Copy link
Contributor

We let only 1 E402 module level import not at top of file, that is an import after all the code related to the module's documentation.

Component: graph theory

Author: David Coudert

Branch/Commit: e03e096

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/34074
@dcoudert dcoudert added this to the sage-9.7 milestone Jun 25, 2022
@dcoudert
Copy link
Contributor Author

New commits:

4528211trac #34074: cleanup src/sage/graphs/graph_generators.py

@dcoudert
Copy link
Contributor Author

Commit: 4528211

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/34074_gen

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2022

Changed commit from 4528211 to e03e096

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e03e096trac #34074: fix merge conflict with 9.7.beta5

@dcoudert
Copy link
Contributor Author

comment:3

Possible conflict with #34148.

@videlec
Copy link
Contributor

videlec commented Aug 1, 2022

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Aug 1, 2022

comment:5

Do you want to merge #34148 in the branch?

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 1, 2022

comment:6

Unless I'm mistaken, #34148 has been included in 9.7.beta6 and I can rebase this ticket on top of it without conflict. So it should be ok.

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

comment:7

I see no merge conflict with 9.7.beta 8. I set back this ticket to positive.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from public/graphs/34074_gen to e03e096

@vbraun vbraun closed this as completed in d11634a Aug 30, 2022
@dcoudert dcoudert mentioned this issue Jul 11, 2022
Closed
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 29, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @videlec @dcoudert