Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and activate pycodestyle E306 #34148

Closed
fchapoton opened this issue Jul 11, 2022 · 8 comments
Closed

fix and activate pycodestyle E306 #34148

fchapoton opened this issue Jul 11, 2022 · 8 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

about blank line before any nested definition

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: b73ee74

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34148
@fchapoton fchapoton added this to the sage-9.7 milestone Jul 11, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34148

@fchapoton
Copy link
Contributor Author

New commits:

b73ee74fix and activate pycodestyle E306

@fchapoton
Copy link
Contributor Author

Commit: b73ee74

@dcoudert
Copy link
Contributor

comment:2

Changes in src/sage/graphs/graph_generators.py are also done in #34074.

@fchapoton
Copy link
Contributor Author

comment:3

merci pour le signalement. Je fusionnerai en temps utile.

@dcoudert
Copy link
Contributor

comment:4

LGTM.

on règlera le conflit dans #34074 je suppose.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Jul 17, 2022

Changed branch from u/chapoton/34148 to b73ee74

@vbraun vbraun closed this as completed in 17b1c17 Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert