-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PEP420 namespace package support from Cython 3 #34221
Comments
New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
This solved all of the problems that I ran into with the p_group_cohomology and sage_numerical_backends_coin packages. The problems were caused by cython not finding the .pxd files that were needed for cimport statements. With this patch the cimports worked and I got a successful build of 9.7.beta6 on an arm64 mac with a minimal environment. |
comment:6
Thanks for testing! |
Dependencies: #34237 |
comment:11
This works for me and also fixes the problems with |
Reviewer: Marc Culler, John Palmieri |
comment:12
Thanks! |
comment:14
@jhpalmieri - the p_group_cohomology issue can be fixed by adding a symlink. |
comment:15
Thank you, I added that link to the discussion at #30787. |
comment:16
For my information, is this needed to build sage now? Or will it be needed once we split sagelib for real? |
comment:17
It's not needed for building sagelib, but it is needed for building other packages as described in the ticket description |
comment:18
For downstream packages, yes. But I am assuming that once we split sagelib, the modules may need it too - but that's in the future. |
comment:19
The modularized packages such as |
comment:20
Thank you for answering my pesky questions. |
Changed branch from u/mkoeppe/backport_pep420_namespace_package_support_from_cython_3 to |
After #33011, downstream packages that use Cython and
cimport
Sage modules need to activate PEP 420 namespace package support in Cython usingwith cython_namespace_package_support
(as is done in https://github.com/sagemath/sage-prod/blob/develop/src/setup.py#L106 for sagelib).This feature is standard in the upcoming Cython 3 (#29863). Until downstream packages are updated, we can patch our Cython.
Upstream backport PR:
Depends on #34237
CC: @culler @tscrim @videlec @jhpalmieri
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
48a9ba2
Reviewer: Marc Culler, John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/34221
The text was updated successfully, but these errors were encountered: