-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate FiniteEnumeratedSet in the global namespace, add method is_subset to Sets.ParentMethods #34398
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Last 10 new commits:
|
Commit: |
mkoeppe
changed the title
Deprecate FiniteEnumeratedSet in the global namespace
Deprecate FiniteEnumeratedSet in the global namespace, add method is_subset to EnumeratedSets
Aug 21, 2022
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
Deprecate FiniteEnumeratedSet in the global namespace, add method is_subset to EnumeratedSets
Deprecate FiniteEnumeratedSet in the global namespace, add method is_subset to Sets.ParentMethods
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We unify the classes
Set_object_enumerated
andFiniteEnumeratedSet
.The only difference should be that one uses a
frozenset
(fast look ups, slow indexing via iteration), the other uses atuple
(slow look ups, fast indexing). And we should have the option to get both operations fast. We get this for free by the categoryFiniteEnumeratedSets
.We add to the methods provided by
Sets.ParentMethods
:is_subset
etc. (as defined forRealSet
andManifoldSubset
) via discovery of inclusion morphisms (see FacadeInclusionMorphism #34461)We add to the methods provided by
FiniteEnumeratedSets.ParentMethods
:frozenset
(to complementlist
)is_subset
etc. by iteration or delegating tofrozenset
issubset
etc. used by the Python library) for finite enumerated sets - for interoperability with Pythonset
,frozenset
Then we deprecate the import of
FiniteEnumeratedSet
in the global namespace in favor of using the constructorSet
.CC: @tscrim
Component: combinatorics
Branch/Commit: u/mkoeppe/deprecate_finiteenumeratedset_in_the_global_namespace @
cca78af
Issue created by migration from https://trac.sagemath.org/ticket/34398
The text was updated successfully, but these errors were encountered: