Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pillow to 9.2.0, update spkg-install to use --config-settings #34433

Closed
mkoeppe opened this issue Aug 25, 2022 · 8 comments
Closed

Upgrade pillow to 9.2.0, update spkg-install to use --config-settings #34433

mkoeppe opened this issue Aug 25, 2022 · 8 comments
Labels
c: build p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 25, 2022

We upgrade pillow to 9.2.0

We modernize how we pass build options to the package, using the PEP 517 --config-settings mechanism. This is the same as in #34421, where it was needed as a critical bug fix. (For pillow there is no bug because the analysis in #33138 is still true for our current version of pillow.)

Depends on #34344

CC: @dimpase @isuruf

Component: build

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/upgrade_pillow_to_9_2_0__fix_spkg_install_to_use___config_settings @ 36ece20

Issue created by migration from https://trac.sagemath.org/ticket/34433
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 25, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Branch: u/mkoeppe/upgrade_pillow_to_9_2_0__fix_spkg_install_to_use___config_settings

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Commit: 36ece20

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

New commits:

418001ebuild/pkgs/pillow: Update to 9.2.0
24baa5cbuild/pkgs/pillow/spkg-install.in: Remove ancient workarounds, outdated comment
2a76bc1build/pkgs/pillow/spkg-install.in: Do not pass -I and -L to build_ext; setup.py no longer handles them
f42e830build/bin/sage-dist-helpers (sdh_prefix_args_equals_unquoted): New
36ece20build/pkgs/pillow/spkg-install.in: Use pip --config-settings

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 25, 2022
@mkoeppe mkoeppe changed the title Upgrade pillow to 9.2.0, fix spkg-install to use --config-settings Upgrade pillow to 9.2.0, update spkg-install to use --config-settings Aug 25, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

comment:5

This will have to wait for the setuptools upgrade (#34344) because of limitations of our current setuptools version; see the comments added on the branch of #34430.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Dependencies: #34344

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 29, 2023

outdated, we already have 10.0.1

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkoeppe