Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAGE_FAT_BINARY regression for numpy ("Ignoring --build-option when building numpy using PEP 517") #33138

Closed
mkoeppe opened this issue Jan 10, 2022 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 10, 2022

Seen in https://github.com/sagemath/sage-prod/files/10659599/numpy-1.21.4.log

The change made as part of #32046, using pip wheel --build-option ... (instead of setup.py bdist_wheel...) seems to have broken the use of said build options when the package is a PEP 517 package (i.e., has pyproject.toml)

Among the packages found by git grep sdh_prefix, only numpy is
affected (the others, python_igraph, jupyter_jsmol, pillow, do not have pyproject.toml).

The build options for numpy are in particular needed for SAGE_FAT_BINARY=yes builds. This would explain the segfaults (again!) in the multi-stage Cygwin build, triggered by plots in doctests - https://github.com/sagemath/sage/runs/4768915607?check_suite_focus=true

(Hence "blocker" for Sage 9.5.)

Also fixes a build problem on alpine-standard (#33083)

CC: @dimpase @kliem @jhpalmieri @culler

Component: packages: standard

Author: Matthias Koeppe

Branch: 455e1fa

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33138

@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 10, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

New commits:

455e1fabuild/pkgs/numpy/spkg-install.in: Use pip wheel --no-use-pep517

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

Commit: 455e1fa

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title Ignoring --build-option when building numpy using PEP 517 Fix "Ignoring --build-option when building numpy using PEP 517" Jan 10, 2022
@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jan 10, 2022

comment:5

see #33083 comment:45 - it throws an error, saying that
setup.py clean is not supported.
(this is actually a by-product of a failing build)

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Fix "Ignoring --build-option when building numpy using PEP 517" Fix SAGE_FAT_BINARY regression for numpy ("Ignoring --build-option when building numpy using PEP 517") Jan 12, 2022
@dimpase
Copy link
Member

dimpase commented Jan 12, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jan 12, 2022

comment:8

OK, assuming the inability to build on Alpine in lxc (as reported on #33083) has nothing to do with this.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 12, 2022

comment:9

Thanks.

@vbraun
Copy link
Member

vbraun commented Jan 12, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Changed commit from 455e1fa to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Replying to @mkoeppe:

Among the packages found by git grep sdh_prefix, only numpy is
affected (the others, python_igraph, jupyter_jsmol, pillow, do not have pyproject.toml).

Follow-up for these packages in #34430, #34421, #34433.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants