-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SAGE_FAT_BINARY regression for numpy ("Ignoring --build-option when building numpy using PEP 517") #33138
Comments
New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:5
see #33083 comment:45 - it throws an error, saying that |
This comment has been minimized.
This comment has been minimized.
Reviewer: Dima Pasechnik |
comment:8
OK, assuming the inability to build on Alpine in lxc (as reported on #33083) has nothing to do with this. |
comment:9
Thanks. |
Changed branch from u/mkoeppe/ignoring___build_option_when_building_numpy_using_pep_517 to |
Changed commit from |
Seen in https://github.com/sagemath/sage-prod/files/10659599/numpy-1.21.4.log
The change made as part of #32046, using
pip wheel --build-option ...
(instead ofsetup.py bdist_wheel...
) seems to have broken the use of said build options when the package is a PEP 517 package (i.e., haspyproject.toml
)Among the packages found by
git grep sdh_prefix
, only numpy isaffected (the others,
python_igraph
,jupyter_jsmol
,pillow
, do not havepyproject.toml
).The build options for numpy are in particular needed for
SAGE_FAT_BINARY=yes
builds. This would explain the segfaults (again!) in the multi-stage Cygwin build, triggered by plots in doctests - https://github.com/sagemath/sage/runs/4768915607?check_suite_focus=true(Hence "blocker" for Sage 9.5.)
Also fixes a build problem on
alpine-standard
(#33083)CC: @dimpase @kliem @jhpalmieri @culler
Component: packages: standard
Author: Matthias Koeppe
Branch:
455e1fa
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33138
The text was updated successfully, but these errors were encountered: