Most extensions don't need to be listed in module_list

[robertwb]

Unless special libraries or C flags are needed, we can auto-generate almost this whole list, which simplifies the making of new .pyx files in the standard library.

I am sure this needs rebasing WRT any new modules that have been added.

See also #15410.

CC: @williamstein @mwhansen @jasongrout @nexttime

Component: build

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/7987

[robertwb]

comment:1

Eventually, the library, include, and language information should be able to be pulled out of the files themselves by Cython...

[robertwb]

Attachment: 7987-module_list-cleanup.patch.gz

[robertwb]

comment:3

Eventually, this should be part of Cython. Also, clang, clib, etc. should be allowed in .pxd files and be transitive (for example, everything using Pynac or NTL would automatically be C++ and get the right library).

[robertwb]

comment:5

I will probably implement something like this in Cython directly, though of course heavily inspired by what we want for Sage.

[nexttime]

comment:7

Not surprising (see ticket description), the patches need to be rebased.

The merged Cygwin patch involved many changes to module_list.py, too.

Btw, IMHO libcsage and libstdcxx should not be "linked" unconditionally (especially regardless of the module's language) to each and every module.
(I recently started sorting out which modules really directly use libcsage, and did add "stdcxx" to libraries only if language=="c++". Currently suspended work in progress...)

[robertwb]

comment:8

Replying to @nexttime:

Btw, IMHO libcsage and libstdcxx should not be "linked" unconditionally (especially regardless of the module's language) to each and every module.
(I recently started sorting out which modules really directly use libcsage, and did add "stdcxx" to libraries only if language=="c++". Currently suspended work in progress...)

For sure, but I figured it'd be better to refractor and clean things up in separate steps (in case one or the other has unintended consequences).

For the record, I plan to add this functionality to Cython soon (including transitivity of library dependance), so that may make this patch invalid. Sorting what modules actually need what will be very useful though.

[nexttime]

comment:9

Replying to @robertwb:

Replying to @nexttime:

Btw, IMHO libcsage and libstdcxx should not be "linked" unconditionally (especially regardless of the module's language) to each and every module.
(I recently started sorting out which modules really directly use libcsage, and did add "stdcxx" to libraries only if language=="c++". Currently suspended work in progress...)

For sure, but I figured it'd be better to refractor and clean things up in separate steps (in case one or the other has unintended consequences).

Yes. The unconditional inclusion is anyhow performed in setup.py.

For the record, I plan to add this functionality to Cython soon (including transitivity of library dependance), so that may make this patch invalid. Sorting what modules actually need what will be very useful though.

I just wanted to decrease the number of tickets needing review. ;-)

P.S.: s/stdcxx/stdc++/

[nexttime]

Replying to @jdemeyer:

See also #15140.

Sure?

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

comment:18

This is way too outdated to apply, it also incorrectly adds the libraries to .pyx files instead of .pxd files (see #18450) and several parts of this have already been done.