Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show explicit formulas in documentation of WeierstrassIsomorphism #34967

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 6, 2023

Fixes #34439.

@yyyyx4 yyyyx4 force-pushed the public/show_formulas_in_WeierstrassIsomorphism_documentation branch from 16023ae to a89cc3c Compare February 8, 2023 02:38
@yyyyx4 yyyyx4 requested a review from kwankyu February 8, 2023 02:46
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a89cc3c) compared to base (64cfac5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a89cc3c differs from pull request most recent head 83581fa. Consider uploading reports for the commit 83581fa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34967      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396142   396141       -1     
===========================================
- Hits        350979   350954      -25     
- Misses       45163    45187      +24     
Impacted Files Coverage Δ
...ge/schemes/elliptic_curves/weierstrass_morphism.py 93.01% <100.00%> (ø)
...e/combinat/cluster_algebra_quiver/mutation_type.py 50.11% <0.00%> (-3.69%) ⬇️
src/sage/modular/arithgroup/congroup_gamma0.py 94.41% <0.00%> (-0.56%) ⬇️
src/sage/matrix/matrix_integer_dense_hnf.py 85.71% <0.00%> (-0.51%) ⬇️
src/sage/cpython/_py2_random.py 76.03% <0.00%> (-0.42%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/cardinality.py 87.00% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.40%) ⬇️
src/sage/matrix/special.py 93.62% <0.00%> (-0.27%) ⬇️
src/sage/schemes/elliptic_curves/ell_point.py 84.49% <0.00%> (-0.14%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4
Copy link
Member Author

yyyyx4 commented Feb 8, 2023

The test failure is unrelated (see #35017).

@vbraun vbraun merged commit a10cf50 into sagemath:develop Feb 19, 2023
@yyyyx4 yyyyx4 deleted the public/show_formulas_in_WeierstrassIsomorphism_documentation branch February 20, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show explicit formulas in documentation of WeierstrassIsomorphism
6 participants