Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute matrix kernels modulo composites #34968

Merged

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 6, 2023

Fixes #34862.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.58% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (fe50906) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34968      +/-   ##
===========================================
- Coverage    88.58%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396961              
===========================================
- Hits        351655   351654       -1     
- Misses       45306    45307       +1     
Impacted Files Coverage Δ
...c/sage/geometry/polyhedron/ppl_lattice_polytope.py 96.52% <ø> (ø)
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/graphs/generators/random.py 91.26% <0.00%> (-1.03%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/cardinality.py 87.00% <0.00%> (-0.40%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/schemes/elliptic_curves/ell_generic.py 93.23% <0.00%> (-0.14%) ⬇️
src/sage/graphs/digraph.py 92.58% <0.00%> (-0.13%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4 yyyyx4 force-pushed the public/matrix_kernels_modulo_composites branch from 27b6732 to fe50906 Compare February 14, 2023 00:20
src/sage/matrix/matrix2.pyx Outdated Show resolved Hide resolved
src/sage/matrix/matrix2.pyx Show resolved Hide resolved
@yyyyx4 yyyyx4 force-pushed the public/matrix_kernels_modulo_composites branch from fe50906 to c028ed7 Compare February 15, 2023 16:55
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: c028ed7

@yyyyx4
Copy link
Member Author

yyyyx4 commented Feb 16, 2023

Thanks for the review!

@vbraun vbraun merged commit 0b88463 into sagemath:develop Feb 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 19, 2023
@yyyyx4 yyyyx4 deleted the public/matrix_kernels_modulo_composites branch February 20, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute matrix kernels modulo composites
6 participants