-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-link matrix methods image and column_space #34972
Conversation
Hello everyone, I have created this pull request in view of changes committed by me in the open issue #33548 ,Please tell if anything else needs to be done to merge this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. It would be better to keep a single commit with the final version of the changes instead of adding 3 additional useless commits to the history, though.
Sir I would rebase my branch shortly, actually my system isn't working properly for few days, so it is taking time. |
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34972 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 2136 2136
Lines 396142 396142
========================================
+ Hits 350948 350953 +5
+ Misses 45194 45189 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3624ad7
to
0dc758a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is my pull request originally created on trac, which I thought pushing on github.
Fixes #33548