Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tachyon >= 0.99.2 #34995

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Support for tachyon >= 0.99.2 #34995

merged 2 commits into from
Mar 3, 2023

Commits on Feb 9, 2023

  1. sagemath#34995 (trac sagemath#23712): support tachyon >= 0.99.2

    In tachyon 0.99.2 the keyword `focallength` was changed to `focaldist`.
    To support it, when running on version >= 0.99.2 we "patch" the model as
    constructed by class `sage.plot.plot3d.tachyon.Tachyon`.
    
    In the future (possibly when tachyon in sage gets upgraded), all the
    focallength occurences in sage.plot.plot3d.tachyon can be replaced by
    focaldist for consistency with new tachyon, and the logic here can be
    reversed (i.e. patch the model when self.version() < '0.99.2') or just
    drop support for old versions.
    tornaria committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    5734d2a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. sagemath#34995: support debian version of tachyon

    Debian patches tachyon so it won't report the version.
    
    We hardcode '0.99' since that's the version they ship.
    tornaria committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2252d38 View commit details
    Browse the repository at this point in the history