Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doctest for #13569 #35010

Merged
merged 1 commit into from
Feb 24, 2023
Merged

add doctest for #13569 #35010

merged 1 commit into from
Feb 24, 2023

Conversation

mezzarobba
Copy link
Member

Closes #13569.

@edgarcosta edgarcosta self-requested a review February 7, 2023 23:26
edgarcosta
edgarcosta suggested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@edgarcosta edgarcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a reference to the test saying:
This test addresses ticket ...

However, I am unsure of the format now that we are using GitHub

@edgarcosta
Copy link
Member

I heard back from @roed314, and it is okay to have

This test addresses ticket :trac:`13569`::

@mezzarobba
Copy link
Member Author

mezzarobba commented Feb 8, 2023 via email

fchapoton
fchapoton approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good to go

@roed314 roed314 self-requested a review February 8, 2023 16:49
@vbraun vbraun merged commit c6508c5 into sagemath:develop Feb 24, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 24, 2023
@mezzarobba mezzarobba deleted the test-13569 branch December 6, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarcosta edgarcosta edgarcosta requested changes

@fchapoton fchapoton fchapoton approved these changes

@roed314 roed314 roed314 approved these changes

Assignees
No one assigned
Labels
c: group theory t: tests
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

group multiplication seems to depend on order sometimes
6 participants
@mezzarobba @edgarcosta @roed314 @fchapoton @vbraun @mkoeppe