Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __getitem__ and alias weight methods for quasimodular forms #35025

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

DavidAyotte
Copy link
Member

@DavidAyotte DavidAyotte commented Feb 8, 2023

📚 Description

This PR implements a __getitem__ method for quasimodular forms ring elements to access their components of a fixed degree. Moreover, the PR defines the alias degree = weight (which is the right nomenclature for elements of a graded algebra, as discussed with @fchapoton).

@videlec

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@videlec
Copy link
Contributor

videlec commented Feb 8, 2023

Where the convention about homogeneous_component is actually taken from?

$ git grep -l homogeneous_component categories/*py
categories/filtered_modules_with_basis.py
categories/finite_dimensional_graded_lie_algebras_with_basis.py
categories/finite_dimensional_lie_algebras_with_basis.py

None of these categories match the quasi-modular forms.

@videlec
Copy link
Contributor

videlec commented Feb 8, 2023

Where the convention about homogeneous_component is actually taken from?

$ git grep -l homogeneous_component categories/*py
categories/filtered_modules_with_basis.py
categories/finite_dimensional_graded_lie_algebras_with_basis.py
categories/finite_dimensional_lie_algebras_with_basis.py

None of these categories match the quasi-modular forms.

All right. As discussed with David, the homogeneous_component that appears in the patch comes from the quasi-modular forms and is not introduce here.

@DavidAyotte
Copy link
Member Author

Thank you!

@vbraun vbraun merged commit c0cf536 into sagemath:develop Mar 3, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants