-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default devcontainer using conda #35072
Conversation
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35072 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2140 2140
Lines 396961 396961
===========================================
- Hits 351678 351653 -25
- Misses 45283 45308 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
That's great news! |
The devcontainer doesn't build for me and enters recovery mode. |
And what is the error? |
Do you know where I find the errors after it has sent me to the "recovery container"? |
They should show up automatically in the recovery container. But you can also show the log using the "Dev Containers: Show Container Log" command. |
|
Looks like you run in out of your docker space quota microsoft/vscode-dev-containers#128. |
The failing run was in the cloud, not on my machine |
Did you use the 8GB RAM runner? Once we enable prebuilds these limits shouldn't be an issue any more. Can you please try it locally? |
Locally it works fine. I suppose we can look into the codespaces situation later, so I would set it to positive review after you take care of the documentation |
Okay, thanks! I've now incorporated your suggestions. |
Documentation preview for this PR is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
The build & test failure is an unrelated doctest timeout. |
Thanks! Merging now as its only dx related. |
📚 Description
Now that VSCode support multiple devcontainer configs, we can add a default config that uses conda (similar to the gitpod config). Closes #34560.
Once this PR is merged, I will enable codespace prebuilds so that one can get a running codespace very quickly without the 40min of build time. Example of such a prebuild run can be found at https://github.com/tobiasdiez/sage/actions/runs/4150784209/jobs/7180663661.
📝 Checklist
⌛ Dependencies