Remove 'docker' from the names of the Docker images published on ghcr.io #35079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "build" workflows fail here exactly because of the rename -- it cannot fetch the prebuilt image because it now expects a different name. |
|
If this is merged as is, do then not all PRs based on the develop will fail as well until the required images are build and published? Maybe split this PR into two stages: first publish images under the new name, second use the new images in the workflows/devcontainer? |
|
I think this is a minor concern because of the way that we merge: develop is only advanced at the push of the next beta tag. This triggers the the necessary image build. |
|
But I don't mind splitting it up. |
mkoeppe
force-pushed
the
rename_gh_packages
branch
from
43edbf0
to
18f4210
Compare
|
Here we go. |
tobiasdiez
approved these changes
Feb 12, 2023
|
Thanks! |
Codecov ReportBase: 88.60% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35079 +/- ##
===========================================
- Coverage 88.60% 88.59% -0.02%
===========================================
Files 2136 2136
Lines 396142 396142
===========================================
- Hits 350990 350948 -42
- Misses 45152 45194 +42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
do we want this to go to develop now? |
Yes, ASAP, but I think you'll need to coordinate with @vbraun |
|
Sorry, made a stupid mistake. Fixed now (see https://github.com/users/mkoeppe/packages?repo_name=sage) |
vbraun
pushed a commit
that referenced
this pull request
Mar 26, 2023
… in the name
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
<!-- Describe your changes here in detail -->
Step 2 of the rename done in #35079.
<!-- Why is this change required? What problem does it solve? -->
Step 2 make sure that multi-stage workflows and devcontainers use the
most current image, not the last image before the migration.
The "build" and "build-doc" workflows will be updated in a 3rd (and
final) step.
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [ ] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
This should only be merged when the images with the new names have been
pushed.
URL: #35080
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
that referenced
this pull request
Apr 1, 2023
… in the name (step 3)
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Step 3 of the rename done in #35079 and #35080.
This will speed up the "Build & Test" and "Build documentation"
workflows because they will start from more recent images.
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
URL: #35278
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
We shorten the names of the Docker images generated by our portability tests slightly by removing the redundant word
dockerfrom it.This is done because the previously used names still belong to the old repository (which is now renamed as sagemath/sage-archive-...), and the new repository does not have permissions to push new versions there.
This can be changed package by package in the web interface, but there is no API for doing so and we have over 1000 packages. So instead we change the naming pattern; the removal of the redundant word is a welcome side effect.
📝 Checklist
⌛ Dependencies