Fix a slow doctest in matrix_integer_dense_hnf.py #35162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hnf for integer dense matrices is quite slow, reported in sagemath#35161. While that issue is resolved, it doesn't make sense to keep this very slow test, so tune it down to an acceptable time.
|
Documentation preview for this PR is ready! 🎉 |
Codecov ReportBase: 88.59% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35162 +/- ##
===========================================
- Coverage 88.59% 88.59% -0.01%
===========================================
Files 2140 2140
Lines 396998 396998
===========================================
- Hits 351740 351709 -31
- Misses 45258 45289 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tornaria
deleted the
slow_doctest-sage/matrix/matrix_integer_dense_hnf.py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hnf for integer dense matrices is quite slow, reported in #35161. While that issue is resolved, it doesn't make sense to keep this very slow test, so tune it down to an acceptable time.
📚 Description
📝 Checklist
⌛ Dependencies