Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for Specht modules and diagrams #35432

Merged
merged 3 commits into from
May 22, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Apr 4, 2023

📚 Description

This fixes a bug in the Specht modules when the cells of the diagram are bigger than the number of boxes:

sage: SGA = SymmetricGroupAlgebra(QQ, 2)
sage: SGA.specht_module([(2,2), (5,5)])
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
...
IndexError: list index out of range

We also fix a few typos in combinat/diagram.py.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim tscrim requested a review from trevorkarn April 4, 2023 03:04
@tscrim
Copy link
Collaborator Author

tscrim commented Apr 4, 2023

@darijgr This is the fix to Specht modules (and to diagram.py) you told me about. The problem was a bit different than you were thinking. The n is correct; it is the number of boxes. However, how I was building/checking the diagram was with the wrong size. In fact, this change can make it much more efficient for "dense" diagrams.

@mkoeppe Can you promote @darijgr to the "triage" team?

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 4, 2023

Done

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 4, 2023

Thank you.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: f0494de

Copy link
Contributor

@darijgr darijgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are good.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 19, 2023

Thank you.

@vbraun vbraun merged commit b02631d into sagemath:develop May 22, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
@tscrim tscrim deleted the combinat/specht_module_fixes branch May 23, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants