Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cython-linting in modular/ folder #35516

Merged
merged 3 commits into from
May 22, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This fixes some of the issues found by cython-lint in the modular folder. The command used was

cython-lint --ignore=E501,E265,E231,E127,E266,E741 src/sage/modular/

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: ea35699

@dcoudert
Copy link
Contributor

You have not considered the comments I made, but it can be done in a future ticket.

@fchapoton
Copy link
Contributor Author

You have not considered the comments I made, but it can be done in a future ticket.

heu, pardon, mais quels commentaires ?

@dcoudert
Copy link
Contributor

J'avais fait des propositions de modifications du code du type (-cc,dd,&bb,&aa)) -> (-cc, dd, &bb, &aa), un for i from 0 <= i < k: qui reste, etc. Si tu ne vois pas ça sur la page de la pull request, forcément tu ne peux pas en tenir compte.

@vbraun vbraun merged commit e50524a into sagemath:develop May 22, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants