Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace obsolescent egrep #35565

Merged
merged 2 commits into from
May 22, 2023
Merged

replace obsolescent egrep #35565

merged 2 commits into from
May 22, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

replace the last 2 uses of egrep in our source code, using the replacement grep -E

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2023

Or one could get rid of this use of egrep entirely by using find sage -name "*.py" -o -name "*.pxi" .....

@fchapoton
Copy link
Contributor Author

mmmh, this seems to break something. Should I try the proposal using -o ?

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 5ced222

@fchapoton fchapoton changed the title replace obsolescent egrep by grep -E replace obsolescent egrep Apr 26, 2023
@vbraun vbraun merged commit 0772e47 into sagemath:develop May 22, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
@fchapoton fchapoton deleted the no_more_egrep branch July 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: porting t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun