Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details in posets #35573

Merged
merged 1 commit into from
May 22, 2023
Merged

some details in posets #35573

merged 1 commit into from
May 22, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Some small details in code of posets :

  • a few pep8 fixes
  • some changes to try to gain a little speed using .monomial

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 487bf86

mkoeppe
mkoeppe approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 8455792 into sagemath:develop May 22, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
@fchapoton fchapoton deleted the micro-details-in-posets branch July 16, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun