Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Max=Min warning in coin interacts #35596

Merged
merged 1 commit into from
May 28, 2023
Merged

Fix Max=Min warning in coin interacts #35596

merged 1 commit into from
May 28, 2023

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

New versions of matplotlib complained about ymin = ymax (= 0). And I guess it makes more sense to have a float-slider in this case anyway.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez mentioned this pull request May 2, 2023
Closed
11 tasks
@github-actions
Copy link

github-actions bot commented May 2, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: cc1859e

kwankyu
kwankyu approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.

@kwankyu
Copy link
Collaborator

kwankyu commented May 3, 2023

Thanks for fixing this!

@tobiasdiez
Copy link
Contributor Author

Thanks for the review!

@vbraun vbraun merged commit ebb9473 into sagemath:develop May 28, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 28, 2023
@tobiasdiez tobiasdiez deleted the interact_maxmin branch May 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@fchapoton fchapoton Awaiting requested review from fchapoton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @kwankyu @vbraun @mkoeppe