Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation.ffmpeg: Shell-quote filenames #35622

Merged
merged 1 commit into from
May 28, 2023
Merged

Animation.ffmpeg: Shell-quote filenames #35622

merged 1 commit into from
May 28, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 7, 2023

📚 Description

Fixes https://groups.google.com/g/sage-devel/c/gsMDcsBjk5s

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added this to the sage-10.0 milestone May 7, 2023
@mkoeppe mkoeppe self-assigned this May 7, 2023
@github-actions
Copy link

github-actions bot commented May 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 878b846

@kwankyu
Copy link
Collaborator

kwankyu commented May 7, 2023

If you understand why coverage check codecov/patch failed (I don't), could you add a test to satisfy it?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 7, 2023

These doctests are only run when the ffmpeg package is installed; it isn't.

@kwankyu
Copy link
Collaborator

kwankyu commented May 7, 2023

I see. So codecov doesn't understand our optional tag.

kwankyu
kwankyu approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2023

Thank you!

@mkoeppe mkoeppe modified the milestones: sage-10.0, sage-10.1 May 20, 2023
@vbraun vbraun merged commit 42e53e7 into sagemath:develop May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: graphics t: bug
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun