-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix g++ (13) warnings #35679
base: develop
Are you sure you want to change the base?
Fix g++ (13) warnings #35679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
On OSX I get
|
Is that with Xcode "g++"? |
Looking at the C++ doc, it may need to be |
Documentation preview for this PR (built with commit ce15f1e; changes) is ready! 🎉 |
I now see there is |
Yes thats with the Xcode gcc, e.g. BigSur:
|
A change to farey was done in #37646. |
Rebased. |
And that's the bit Volker had problem with. I should redo the branch. |
I would think it is, but it is only fatal if you are strict (which is a promised future behaviour). |
This PR fix two gcc warnings for C++ standard methods deprecated since the C++11 standard.
Fixes #34996
📝 Checklist
⌛ Dependencies