Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylint: remove unused imports in folders [s-z]* #35689

Merged

Conversation

fchapoton
Copy link
Contributor

📚 Description

remove unused imports found by cython-lint in all folders from s* to z*

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim
Copy link
Collaborator

tscrim commented May 29, 2023

Someone did a bad import:

  File "/__w/sage/sage/src/sage/structure/formal_sum.py", line 76, in <module>
    from sage.structure.coerce import LeftModuleAction, RightModuleAction

This is causing the build to fail. :3

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all tests pass. If they do, then set a positive review.

@fchapoton fchapoton force-pushed the cylint-unused-imports-from-s-to-z branch from fa932e8 to f8d3608 Compare May 29, 2023 11:25
@github-actions
Copy link

Documentation preview for this PR (built with commit f8d3608) is ready! 🎉

@fchapoton
Copy link
Contributor Author

thanks, Travis. Now setting to positive. Maybe you should approve the code, as I have squashed the branch.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approval seem to carry over regardless if there are further changes pushed... Anyways, better to reapprove than to have this bitrot.

@vbraun vbraun merged commit e99b5d9 into sagemath:develop Jun 3, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants