-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature annotations # optional - sage.schemes sage.modular sage.libs.flint
etc.
#35728
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d98dfed
sage.features: Add sage.libs.flint, sage.libs.ntl, sage.rings.polynomβ¦
mkoeppe dce0625
sage.structure: Doctest cosmetics, add # optional
mkoeppe 2882223
sage.features: Update tested Python module for feature 'sage.combinat'
mkoeppe 058ff2a
sage.features: Define features 'sage.schemes', 'sage.modular'; add spβ¦
mkoeppe 1744ae9
More # optional - sage.schemes sage.modular
mkoeppe 8199be3
sage.structure: More # optional - sage.modular sage.schemes
mkoeppe 97d240e
src/sage/arith/misc.py: Re-align # optional
mkoeppe 3c002ac
src/sage/features/sagemath.py: Fix alignment of # optional in featureβ¦
mkoeppe ce9a1ad
src/sage/arith/misc.py (primes): Fix bad merge; docstring cosmetics
mkoeppe ae63b52
src/sage/arith/misc.py (factor): Fix bad merge; docstring cosmetics
mkoeppe 6aaf4b9
src/sage/misc/functional.py (sqrt): Re-align # optional
mkoeppe facd551
src/sage/structure/formal_sum.py: Re-align # optional
mkoeppe cd5f1b4
src/sage/structure/parent.pyx: Doctest cosmetics, add # optional
mkoeppe c5ae906
src/sage/structure/parent_old.pyx: Add # optional
mkoeppe 4f968a8
src/sage/structure/unique_representation.py: Add # optional
mkoeppe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# sage.doctest: optional - primecountpy | ||
""" | ||
Utility classes for multi-modular algorithms | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be so cool if all files could be like this one with only the declaration of the overall optional dependencies. Of course it's much more complicated than that in practice as some optional tags concern only a few tests in a file and are really iff some optional package (e.g., igraph) has been installed. But for dependencies that are repeated on almost all lines, it could ease our life to force the entire file to depend on these packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and in some cases we can achieve this by splitting out parts of files to a separate file (but probably we should do this only where it seems natural).
sage.rings.function_field
: Modularization fixesΒ #35230 - to avoid having to mark one half of each of several files by# optional - sage.libs.singular
.sage.combinat
: More# optional
annotationsΒ #35742 (comment)