Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade msolve to 0.5.0, update interface #36103

Merged
merged 2 commits into from
Aug 27, 2023
Merged

upgrade msolve to 0.5.0, update interface #36103

merged 2 commits into from
Aug 27, 2023

Conversation

mezzarobba
Copy link
Member

  • upgrade msolve to 0.5.0
  • add support for Gröbner bases over ℚ to the msolve interface

Fixes #36055.

@github-actions
Copy link

Documentation preview for this PR (built with commit 4aa8a9e; changes) is ready! 🎉

@mezzarobba
Copy link
Member Author

The failing tests are marked optional - sirocco; I don't think the failures have anything to do with the changes in this branch.

mkoeppe
mkoeppe approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mezzarobba
Copy link
Member Author

Thank you for the review!

@vbraun vbraun merged commit ce7457f into sagemath:develop Aug 27, 2023
11 of 13 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
@mezzarobba mezzarobba deleted the msolve-0.5 branch December 6, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: commutative algebra
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

msolve interface is missing support for non-finite fields
3 participants
@mezzarobba @mkoeppe @vbraun