Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using PyLong API instead of legacy PyInt API #36111

Merged
merged 5 commits into from
Sep 10, 2023
Merged

using PyLong API instead of legacy PyInt API #36111

merged 5 commits into from
Sep 10, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Aug 21, 2023 •
edited
Loading

Fixes #36081

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • I have linked a relevant issue or discussion.

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 2, 2023

please rebase

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Documentation preview for this PR (built with commit 52d9d5e; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

no idea if the map_reduced doctest failure is related or not

@fchapoton
Copy link
Contributor Author

I cannot reproduce the map_reduce doctest failure, which seems to be unrelated.

@fchapoton
Copy link
Contributor Author

all tests are passing now

@fchapoton fchapoton mentioned this pull request Sep 8, 2023
Closed
2 tasks
mkoeppe
mkoeppe approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@vbraun vbraun merged commit 88ad3a1 into sagemath:develop Sep 10, 2023
15 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 10, 2023
@fchapoton fchapoton deleted the using_PyLong_API branch September 11, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
p: major / 3 t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

get rid of obsolete PyInt_* and PyInt_*
3 participants
@fchapoton @mkoeppe @vbraun