Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Conrey number of trivial Dirichlet character #36139

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix Conrey number of trivial Dirichlet character #36139

merged 1 commit into from
Sep 1, 2023

Conversation

fchapoton
Copy link
Contributor

fix #35628, the Conrey number should be 1

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.

@github-actions
Copy link

Documentation preview for this PR (built with commit 1b815e0; changes) is ready! 🎉

JohnCremona
JohnCremona approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@JohnCremona JohnCremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth it, at the same time, to return 1 when the modulus is 2 since again there's only one character. It would save a call to pari.

But the change as is is more important since it corrects an incorrect result.

@fchapoton
Copy link
Contributor Author

Thanks. so, positive review ?

@vbraun vbraun merged commit 37377bc into sagemath:develop Sep 1, 2023
14 of 15 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 1, 2023
@fchapoton fchapoton deleted the conrey_one branch September 2, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCremona JohnCremona JohnCremona approved these changes

Assignees
No one assigned
Labels
c: number theory
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

Conrey number of trivial character
4 participants
@fchapoton @JohnCremona @vbraun @mkoeppe