Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation previews using mathjax cdns #36160

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix documentation previews using mathjax cdns #36160

merged 1 commit into from
Sep 1, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Aug 30, 2023 •
edited
Loading

Fixes #36159

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Add SAGE_USE_CDNS=yes Fix documentation previews using mathjax cdns Aug 30, 2023
@kwankyu kwankyu force-pushed the p/fix-documentation-preview branch from ba2d660 to dbac542 Compare August 30, 2023 06:14
@github-actions
Copy link

Documentation preview for this PR (built with commit dbac542; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator Author

kwankyu commented Aug 30, 2023

It works!

@orlitzky
Copy link
Contributor

LGTM thanks

@orlitzky orlitzky mentioned this pull request Aug 30, 2023
Merged
5 tasks
@kwankyu kwankyu mentioned this pull request Sep 1, 2023
Merged
5 tasks
@vbraun vbraun merged commit 57852a8 into sagemath:develop Sep 1, 2023
8 of 11 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 1, 2023
@kwankyu kwankyu deleted the p/fix-documentation-preview branch December 13, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: critical / 2 t: bug
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

Documentation previews are broken due to lack of MathJax javascript
4 participants
@kwankyu @orlitzky @vbraun @mkoeppe