check coprimality of moduli in CRT_basis() #36457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
force-pushed
the
public/check_coprimality_in_crt_basis
branch
from
06955d9
to
67ef84e
Compare
kwankyu
reviewed
Nov 15, 2023
kwankyu
reviewed
Nov 15, 2023
yyyyx4
force-pushed
the
public/check_coprimality_in_crt_basis
branch
from
67ef84e
to
9a4a464
Compare
|
Thanks, done. |
|
Documentation preview for this PR (built with commit 9a4a464; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 4, 2023
The `xgcd()` calls used in this function to compute modular inverses
already compute the greatest common divisor as a byproduct, so we might
as well add the cheap `.is_one()` check. Benchmarking reveals no
measurable timing difference between the two versions.
URL: sagemath#36457
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xgcd()calls used in this function to compute modular inverses already compute the greatest common divisor as a byproduct, so we might as well add the cheap.is_one()check. Benchmarking reveals no measurable timing difference between the two versions.